-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed link's underline from settings UI #15585
Conversation
a027a22
to
f5b7019
Compare
f5b7019
to
6c01f54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix brave/brave-browser#26091 Below upstream's change enabled underline. https://chromium-review.googlesource.com/c/chromium/src/+/3855278 WebUI: Decorate links with underline This is part 1 of decorating all links and all buttons that look like links with the underline to help users better differentiate between normal text and actionable links. This CL updates links on Settings, Extensions, Management, Downloads, and Welcome, as well as updating a couple of global WebUI styles.
6c01f54
to
1a9cb91
Compare
Thanks for the fix. I think it's better if we put the css file in |
Verification PASSED on
Went through the STR/Cases outlined via brave/brave-browser#26091 (comment) and ensured that links weren't being underlined via
|
fix brave/brave-browser#26091
Below upstream's change enabled underline.
https://chromium-review.googlesource.com/c/chromium/src/+/3855278
WebUI: Decorate links with underline
This is part 1 of decorating all links and all buttons that look like links with the underline to help users better differentiate between normal text and actionable links. This CL updates links on Settings, Extensions, Management, Downloads, and Welcome, as well as updating a couple of global WebUI styles.
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See the linked issue