Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR 107 - Links in brave://settings have been underlined and which is inherited from chrome #26091

Closed
GeetaSarvadnya opened this issue Oct 18, 2022 · 2 comments · Fixed by brave/brave-core#15585
Assignees
Labels
bug feature/global-settings Settings at browser level independent of shields settings OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 18, 2022

Description

Links in brave://settings should not be underlined

Steps to Reproduce

  1. Clean profile 1.46.64
  2. Open brave://settings
  3. Links in brave://settings have been underlined and which is inherited from Chromium CR 107

Actual result:

Links in brave://settings have been underlined

Brave Rewards and Learn more links are underlined
image

Expected result:

Discussed with @rebron and @aguscruiz - Links in brave://settings should not be underlined

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.46.64 Chromium: 107.0.5304.36 (Official Build) nightly (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 10 Version 21H2 (Build 19044.2130)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @aguscruiz @emerick

@GeetaSarvadnya GeetaSarvadnya added bug feature/global-settings Settings at browser level independent of shields settings QA/Yes QA/Test-Plan-Specified OS/Desktop labels Oct 18, 2022
@GeetaSarvadnya GeetaSarvadnya changed the title Links in brave://settings should not be underlined CR 107 - Links in brave://settings have been underlined and which is inherited from chrome Oct 18, 2022
@simonhong simonhong self-assigned this Oct 20, 2022
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 21, 2022
simonhong added a commit to brave/brave-core that referenced this issue Oct 21, 2022
fix brave/brave-browser#26091

Below upstream's change enabled underline.
https://chromium-review.googlesource.com/c/chromium/src/+/3855278
WebUI: Decorate links with underline

This is part 1 of decorating all links and all buttons that look like
links with the underline to help users better differentiate between
normal text and actionable links. This CL updates links on Settings,
Extensions, Management, Downloads, and Welcome, as well as updating
a couple of global WebUI styles.
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 24, 2022
@kjozwiak
Copy link
Member

The above requires 1.45.112 or higher for 1.45.x verification 👍

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Oct 25, 2022

Verification PASSED on


Brave | 1.45.113 Chromium: 107.0.5304.62 (Official Build) (64-bit)
-- | --
Revision | 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS | Windows 10 Version 21H2 (Build 19044.2130)

Went through the STR/Cases outlined via #26091 (comment) and ensured that links weren't being underlined via brave://settings as per the following:

Example Example Example Example Example Example
image image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/global-settings Settings at browser level independent of shields settings OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants