Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the bookmrk icon of omnibox autocomplete entry #14567

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 10, 2022

fix brave/brave-browser#24247

Updated icon:
Screen Shot 2022-08-10 at 10 43 25 AM

Current chromium icon:
Screen Shot 2022-08-10 at 10 46 33 AM

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch with clean profile
  2. Open NTP and add brave bookmark item (https://www.brave.com/) via bookmark bar's Add page context menu item
  3. Type brave.com in omnibox and check new icon is used

@simonhong simonhong self-assigned this Aug 10, 2022
@simonhong
Copy link
Member Author

simonhong commented Aug 10, 2022

@aguscruiz PTAL this updated icon is fine.
I got this bookmarks image from figma (Brave essentials in Icons)

Copy link
Collaborator

@aguscruiz aguscruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this icon looks good! As long as it's crisp, let's go with it (can't judge on actual resolution on the screenshot, but it seems fine)

@simonhong simonhong marked this pull request as ready for review August 11, 2022 00:25
@simonhong simonhong force-pushed the update_bookmarks_icon_in_omnibox_popup branch from 8f3a1a3 to 92e4506 Compare August 11, 2022 00:27
@simonhong simonhong merged commit e379425 into master Aug 11, 2022
@simonhong simonhong deleted the update_bookmarks_icon_in_omnibox_popup branch August 11, 2022 04:09
@simonhong simonhong added this to the 1.44.x - Nightly milestone Aug 11, 2022
simonhong added a commit that referenced this pull request Aug 16, 2022
fix brave/brave-browser#24247

f/u for #14567
Added more margin to icon to make it show smaller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromium bookmarks icon is displayed in search suggestions
2 participants