-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chromium bookmarks icon is displayed in search suggestions #24247
Closed
GeetaSarvadnya opened this issue
Jul 25, 2022
· 3 comments
· Fixed by brave/brave-core#14567 or brave/brave-core#14668
Closed
Chromium bookmarks icon is displayed in search suggestions #24247
GeetaSarvadnya opened this issue
Jul 25, 2022
· 3 comments
· Fixed by brave/brave-core#14567 or brave/brave-core#14668
Labels
bug
OS/Desktop
priority/P4
Planned work. We expect to get to it "soon".
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
cc: @simonhong When you get a chance, can you take a look. |
25 tasks
simonhong
added a commit
to brave/brave-core
that referenced
this issue
Aug 11, 2022
25 tasks
simonhong
added a commit
to brave/brave-core
that referenced
this issue
Aug 16, 2022
fix brave/brave-browser#24247 f/u for #14567 Added more margin to icon to make it show smaller.
rebron
changed the title
Chromium icon is displayed in search suggestions
Chromium bookmarks icon is displayed in search suggestions
Aug 25, 2022
Verification
Verified using original STR #24247 (comment) Case 1:
Confirmed bookmark icon displayed in the omnibox autocomplete entry
Case 2:
Confirmed no Chromium icons displayed in the omnibox autocomplete entry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
OS/Desktop
priority/P4
Planned work. We expect to get to it "soon".
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Description
Chromium icon is displayed in search suggestions
Steps to Reproduce
Case 1:
hello
in address barhello
suggested result has the chromium iconCase 2:
test
Actual result:
Expected result:
Chromium icon should not be displayed in search suggestions
Reproduces how often:
Easy
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/qa-team @mkarolin @rebron
The text was updated successfully, but these errors were encountered: