Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update whitelist with Apple system pseudo-fonts #14489

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Aug 5, 2022

Resolves brave/brave-browser#24468

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@pilgrim-brave pilgrim-brave merged commit 12a02f9 into master Aug 5, 2022
@pilgrim-brave pilgrim-brave deleted the mpilgrim_update_whitelist_apple_system branch August 5, 2022 19:55
@pilgrim-brave pilgrim-brave restored the mpilgrim_update_whitelist_apple_system branch August 5, 2022 19:55
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 5, 2022
brave-builds pushed a commit that referenced this pull request Aug 5, 2022
brave-builds pushed a commit that referenced this pull request Aug 5, 2022
@LaurenWags
Copy link
Member

Verified using

Brave | 1.44.27 Chromium: 104.0.5112.81 (Official Build) nightly (x86_64)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | macOS Version 12.5 (Build 21G72)

While using 1.42.88, confirmed "Pseudo Fonts" test did not show expected results:

1 42 88

Using 1.44.27, verified "Pseudo Fonts" tests from https://dev-pages.brave.software/fingerprinting/fonts.html per brave/brave-browser#24468 (comment).

  1. Launched 1.44.27 with a clean profile.
  2. Restarted so as to pull griffin seed.
  3. Confirmed "Prevent sites from fingerprinting me based on my language preferences" was enabled per griffin under brave://settings/shields.
  4. Visited https://dev-pages.brave.software/fingerprinting/fonts.html
  5. Followed setup instructions on the page and then ran the tests.
  6. Confirmed "Pseudo Fonts" test passed on both https://dev-pages.brave.software/fingerprinting/fonts.html and https://dev-pages.bravesoftware.com/fingerprinting/fonts.html
Example Example
Screen Shot 2022-08-08 at 12 30 34 PM Screen Shot 2022-08-08 at 12 30 45 PM

@bsclifton bsclifton deleted the mpilgrim_update_whitelist_apple_system branch August 16, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shields breaking text/fonts on some websites (followup)
3 participants