-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shields breaking text/fonts on some websites (followup) #24468
Milestone
Comments
pilgrim-brave
added
QA/Yes
release-notes/include
OS/Android
Fixes related to Android browser functionality
OS/Desktop
labels
Aug 5, 2022
This was referenced Aug 5, 2022
pilgrim-brave
removed
the
OS/Android
Fixes related to Android browser functionality
label
Aug 5, 2022
This was referenced Aug 5, 2022
from @pes10k: QA test: https://dev-pages.brave.software/fingerprinting/fonts.html |
brave-builds
modified the milestones:
1.44.x - Nightly,
1.43.x - Beta,
1.42.x - Release #3
Aug 8, 2022
Requires |
Verified
|
Brave | 1.42.91 Chromium: 104.0.5112.81 (Official Build) (x86_64) |
---|---|
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309} |
OS | macOS Version 13.0 (Build 22A5321d) |
Steps:
- installed
1.42.91
- installed the
Fredoka One
font - launched Brave
- loaded
https://dev-pages.brave.software/fingerprinting/fonts.html
andhttps://dev-pages.bravesoftware.com/fingerprinting/fonts.html
- clicked on
Start tests
- checked the
Pseudo Fonts
section's output
Confirmed the Control
and Test
font were rendered the same and with the same width: 343
pixels
dev-pages.brave.software |
dev-pages.bravesoftware.com/ |
---|---|
Fredoka One
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#23093 (comment)
"""
I experienced this issue and arrived here after some basic troubleshooting and finding that turning down shields allowed our font stack to work as expected. At the time, I was running macOS 12.4 and a slightly outdated version of Brave.
The font stack is Inter, -apple-system, BlinkMacSystemFont, avenir next, avenir, helvetica neue, helvetica, Ubuntu, roboto, noto, segoe ui, arial, sans-serif, and the font that I was seeing was avenir. So the browser was skipping Inter (despite Inter being installed correctly and having worked as expected with this font stack previously) and also skipping the two apple system font declarations. Again, turning down shields allowed the stack to perform as expected.
Next, I updated Brave to 1.42.86, which was after the fix announced above, and that did not improve the issue. Only after updating macOS to 12.5 was the issue resolved.
Hope this helps!
"""
The text was updated successfully, but these errors were encountered: