-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements Uphold /capabilities
spec change.
#14057
Implements Uphold /capabilities
spec change.
#14057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
25c454c
to
040f90d
Compare
...t-native-ledger/src/bat/ledger/internal/endpoint/uphold/get_capabilities/get_capabilities.cc
Outdated
Show resolved
Hide resolved
...t-native-ledger/src/bat/ledger/internal/endpoint/uphold/get_capabilities/get_capabilities.cc
Show resolved
Hide resolved
040f90d
to
71a31c3
Compare
71a31c3
to
16551af
Compare
Verified with
Note - while running the below tests you may encounter known issue brave/brave-browser#16376 on the brave://rewards-internals page. Case 1 - Sufficient capabilities - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page is not open prior to Upgrade - PASSED
Case 2 - Insufficient capabilities, receives=1 with requirements - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page is not open prior to Upgrade - PASSED
Case 4 - Insufficient capabilities, sends=1 with requirements - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page is not open prior to Upgrade - PASSED
Case 3 - Insufficient capabilities, receives=2 - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page not open prior to Upgrade - PASSED
Case 5 - Insufficient capabilities, sends=2 - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page not open prior to Upgrade - PASSED
Case 6 - Insufficient capabilities, receives=1 with requirements, sends=2 - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page not open prior to Upgrade - PASSED
Case 7 - Insufficient capabilities, receives=2, sends=1 with requirements - PASSEDScenario 1 - Clean profile - PASSED
Scenario 2 - Upgrade profile - on brave://rewards page prior to Upgrade - PASSED
Scenario 3 - Upgrade profile - brave://rewards page not open prior to Upgrade - PASSED
Additional NotesTest cases differ slightly from those mentioned in PR due to discussion with Szilard. Confirmed the following with him prior to verification: With the above, Case 1 - no modals/notifications ever (this is happy path, user is all verified and good) |
Resolves brave/brave-browser#23849.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Make sure to edit the response of
/v0/me/capabilities
with Charles Proxy according to the below:receives
:"enabled": true, "requirements": []
sends
:"enabled": true, "requirements": []
receives
1
:receives
:"enabled": true, "requirements": [ "user-must-submit-customer-due-diligence" ]
sends
:"enabled": true, "requirements": []
receives
2
:receives
:"enabled": false, "requirements": []
sends
:"enabled": true, "requirements": []
sends
1
:receives
:"enabled": true, "requirements": []
sends
:"enabled": true, "requirements": [ "user-must-submit-customer-due-diligence" ]
sends
2
:receives
:"enabled": true, "requirements": []
sends
:"enabled": false, "requirements": []
receives
andsends
1
:receives
:"enabled": true, "requirements": [ "user-must-submit-customer-due-diligence" ]
sends
:"enabled": false, "requirements": []
receives
andsends
2
:receives
:"enabled": false, "requirements": []
sends
:"enabled": true, "requirements": [ "user-must-submit-customer-due-diligence" ]
Testing linkage (
2.
-7.
above):PENDING
==>
NOT_CONNECTED
(during linking attempt): only modal – no notification (since they haven't been verified)Upgrade tests (
2.
-7.
above):Make sure you're on
brave://rewards
when upgrading to the new version!VERIFIED
==>
NOT_CONNECTED
(onRewards
page):DELETE /v3/wallet/uphold/[wallet-payment-id]/claim
)Make sure you're not on
brave://rewards
when upgrading to the new version!VERIFIED
==>
NOT_CONNECTED
(onRewards
panel):Rewards
page)DELETE /v3/wallet/uphold/[wallet-payment-id]/claim
)