Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events happening at the same time are logged in reverse order in Rewards internals #16376

Closed
szilardszaloki opened this issue Jun 11, 2021 · 2 comments · Fixed by brave/brave-core#14215
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/exclude

Comments

@szilardszaloki
Copy link
Contributor

Description

We're listing Logged at chronologically from bottom to top, like:

06/11/2021, 03:07:36 PM
06/11/2021, 03:03:19 PM

but we're listing the entries logged at the same time from top to bottom:

06/11/2021, 03:07:36 PM    wallet_connected        uphold/962ef
06/11/2021, 03:07:36 PM    fetch_old_balance       0
06/11/2021, 03:07:36 PM    device_limit_reached    uphold/962ef
06/11/2021, 03:07:36 PM    wallet_disconnected     uphold/962ef

Steps to Reproduce

  1. go to brave://rewards-internals
  2. click Event logs
  3. search for a group of events happening at the same time

Actual result:

E.g.:

...
06/11/2021, 03:07:36 PM    wallet_connected        uphold/962ef
06/11/2021, 03:07:36 PM    fetch_old_balance       0
06/11/2021, 03:07:36 PM    device_limit_reached    uphold/962ef
06/11/2021, 03:07:36 PM    wallet_disconnected     uphold/962ef
06/11/2021, 03:03:19 PM    wallet_connected        uphold/962ef
06/11/2021, 03:03:19 PM    fetch_old_balance       0
06/11/2021, 03:03:19 PM    device_limit_reached    uphold/962ef
06/11/2021, 03:03:19 PM    wallet_disconnected     uphold/962ef
...

Expected result:

E.g.:

...
06/11/2021, 03:07:36 PM    wallet_disconnected     uphold/962ef
06/11/2021, 03:07:36 PM    device_limit_reached    uphold/962ef
06/11/2021, 03:07:36 PM    fetch_old_balance       0
06/11/2021, 03:07:36 PM    wallet_connected        uphold/962ef
06/11/2021, 03:03:19 PM    wallet_disconnected     uphold/962ef
06/11/2021, 03:03:19 PM    device_limit_reached    uphold/962ef
06/11/2021, 03:03:19 PM    fetch_old_balance       0
06/11/2021, 03:03:19 PM    wallet_connected        uphold/962ef
...

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

E.g.:

Brave    1.25.72 Chromium: 91.0.4472.101 (Official Build) (64-bit)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS       Windows 10 OS Version 2009 (Build 19043.1052)

But any version should suffice.

Version/Channel Information:

  • Can you reproduce this issue with the current release? ✔️
  • Can you reproduce this issue with the beta channel? ✔️
  • Can you reproduce this issue with the nightly channel? ✔️

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? ❌
  • Does the issue resolve itself when disabling Brave Rewards? ❌
  • Is the issue reproducible on the latest version of Chrome? ❌

Miscellaneous Information:

@LaurenWags
Copy link
Member

LaurenWags commented Aug 8, 2022

Verified with

Brave | 1.43.61 Chromium: 104.0.5112.81 (Official Build) beta (x86_64)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | macOS Version 12.5 (Build 21G72)

Reproduced issue previously (when testing #23849), the two highlighted boxes below are displayed out of order:

reproduced

Ran same case with 1.43.61 and confirmed that the rows in the Event logs tab of brave://rewards-internals are displayed in expected order:

Screen Shot 2022-08-09 at 10 20 48 AM

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 9, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.43.74, Chromium 104.0.5112.102 on a Google Pixel XL running Android 9.

Confirmed with the wallet_verified and wallet_status_change events, which are inverted in release vs. the correct 1.43.74:

release 1.43.74
Screenshot_20220818-130128 Screenshot_20220818-130428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants