Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave extension: remove shields blocking data for closed tabs #13872

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

petemill
Copy link
Member

Resolves brave/brave-browser#23559

Even though we're fully removing all this code via #13638, fixing this bug might be more palatable for uplift to a release channel.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@petemill petemill self-assigned this Jun 20, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jun 20, 2022
@petemill petemill force-pushed the shields-extension-tab-close-memory branch from 2636719 to 73ec6ff Compare June 20, 2022 23:28
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@petemill
Copy link
Member Author

windows-x86 just failed at the last delta step - all build and tests seems to have passed as well as regular windows, macos, linux, etc.

@petemill petemill merged commit e61026a into master Jun 24, 2022
@petemill petemill deleted the shields-extension-tab-close-memory branch June 24, 2022 03:17
@petemill petemill added this to the 1.42.x - Nightly milestone Jun 24, 2022
petemill added a commit that referenced this pull request Jun 28, 2022
brave extension: remove shields blocking data for closed tabs
@kjozwiak
Copy link
Member

kjozwiak commented Jun 29, 2022

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.42.42 Chromium: 103.0.5060.66 (Official Build) nightly (64-bit)
-- | --
Revision | 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS | Windows 11 Version 21H2 (Build 22000.739)

@brave/qa-team just a heads up that this one is a bit hard to reproduce but essentially you'll need to run through the following STR/Cases with an affected version and then run through the STR/Cases with a version that has the above fix.

  • open a new installation of brave and open the Task manager via More tools
  • open https://www.cnn.com and open another ~10 tabs by opening random links on https://www.cnn.com
  • ensure that you have another Brave window opened without any tabs other than the active brave://newtab
  • close the window with the ~10 CNN tabs
  • restore the same window with the CNN tabs via Settings -> History -> Recently closed
  • cycle through each of the tabs and then close the window with all the tabs once again
  • repeat the above re: closing/re-opening and cycling through the tabs (x30-40 times)

Eventually you'll see that the Extension: Brave process via get to about ~90-100MB after doing the above for ~10-15 times or even more. However, eventually the memory will drop back to about ~30-40MBs.

Now if you repeat the same thing with version that has the above fix, the memory never gets close to ~100MB when running through the same STR/Cases outlined above.

restoreWindows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave extension keeps closed tabs' shields data in memory
4 participants