-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave extension keeps closed tabs' shields data in memory #23559
Comments
The above will require |
Verification
Modified and verified with original testplan from brave/brave-core#13872 (comment) Confirmed with Brave
Steps:
|
Verified
|
Brave | 1.41.91 Chromium: 103.0.5060.114 (Official Build) beta (x86_64) |
---|---|
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124} |
OS | macOS Version 11.6.7 (Build 20G630) |
Steps
Followed @MadhaviSeelam's adaptation (above) of the original testplan: brave/brave-core#13872 (comment)
Reproduced the original issue using 1.31.115.
. The only modification I did to #23559 (comment) was to run 20x
, instead of 45x+
.
Max Extension: Brave
memory usage (in MB):
1.41.91 |
1.36.115 |
---|---|
46.4 |
61.5 |
1.41.91 |
1.36.115 |
---|---|
Verified
|
Brave | 1.41.93 Chromium: 103.0.5060.114 (Official Build) (64-bit) |
---|---|
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124} |
OS | Linux |
Steps
Followed @MadhaviSeelam's adaptation (above) of the original testplan: brave/brave-core#13872 (comment)
Reproduced the original issue using 1.36.115.
. The only modification I did to #23559 (comment) was to run 20x
, instead of 45x+
.
Max Extension: Brave
memory usage (in kilobytes
& MB):
1.41.91 |
1.36.115 |
---|---|
40, 512K (39.6MB) |
52, 256K (51.0MB) |
1.41.91 |
1.36.115 |
---|---|
This will allow memory to grow for this specific process (brave extension), unchecked.
STR:
The code this touches isn't even used. It's old code to support the previous version of the shields UI (which used the shields extension), which is useable via the flag but doesn't affect this bug, which has always been present in brave-core from what I can tell. It will be completely removed in #23285
The text was updated successfully, but these errors were encountered: