Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanently delete sync account #13562

Merged
merged 29 commits into from
Dec 20, 2022
Merged

Permanently delete sync account #13562

merged 29 commits into from
Dec 20, 2022

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Jun 1, 2022

Resolves brave/brave-browser#22884

This PR introduces ability to permanently delete the sync chain for desktop and Android.

Related server changes: https://github.com/brave/go-sync/compare/102-add-account-delete

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one - requested
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Pls see #13562 (comment)

@AlexeyBarabash AlexeyBarabash added feature/sync CI/skip Do not run CI builds (except noplatform) labels Jun 1, 2022
@AlexeyBarabash AlexeyBarabash self-assigned this Jun 1, 2022
@AlexeyBarabash AlexeyBarabash changed the title Permanently delete account button on desktop Permanently delete sync account Jun 2, 2022
@AlexeyBarabash AlexeyBarabash force-pushed the sync_perman_del_acc branch 3 times, most recently from bcc7a5b to 20584f9 Compare June 14, 2022 13:31
@AlexeyBarabash AlexeyBarabash force-pushed the sync_perman_del_acc branch 2 times, most recently from 3d7bcc5 to 747b868 Compare June 22, 2022 09:47
@AlexeyBarabash AlexeyBarabash force-pushed the sync_perman_del_acc branch 4 times, most recently from a4b8257 to c0cab03 Compare June 29, 2022 21:08
@AlexeyBarabash AlexeyBarabash force-pushed the sync_perman_del_acc branch 4 times, most recently from e496045 to 8af8ff0 Compare July 11, 2022 19:56
@AlexeyBarabash AlexeyBarabash force-pushed the sync_perman_del_acc branch 11 times, most recently from 6df80d8 to 989ea5c Compare July 15, 2022 19:51
@AlexeyBarabash AlexeyBarabash force-pushed the sync_perman_del_acc branch 2 times, most recently from 82649bf to a557592 Compare August 19, 2022 19:22
This Brave Sync account was deleted from other device. If you didn’t mean to remove the Sync, _re-create the account_

[OK]
This Brave Sync account was deleted from other device. If you didn’t mean to remove the Sync, _re-create the account_  [OK]

introduced BraveSyncAccountDeletedInfoBar class for ConfirmInfoBar customization
Addresses and more => Addresses, payment info, etc.
Apps => Web apps (PWAs)
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Sync security improvements: Delete account
8 participants