-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permanently delete sync account #13562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyBarabash
added
feature/sync
CI/skip
Do not run CI builds (except noplatform)
labels
Jun 1, 2022
AlexeyBarabash
changed the title
Permanently delete account button on desktop
Permanently delete sync account
Jun 2, 2022
AlexeyBarabash
force-pushed
the
sync_perman_del_acc
branch
3 times, most recently
from
June 14, 2022 13:31
bcc7a5b
to
20584f9
Compare
AlexeyBarabash
force-pushed
the
sync_perman_del_acc
branch
2 times, most recently
from
June 22, 2022 09:47
3d7bcc5
to
747b868
Compare
AlexeyBarabash
force-pushed
the
sync_perman_del_acc
branch
4 times, most recently
from
June 29, 2022 21:08
a4b8257
to
c0cab03
Compare
AlexeyBarabash
force-pushed
the
sync_perman_del_acc
branch
4 times, most recently
from
July 11, 2022 19:56
e496045
to
8af8ff0
Compare
AlexeyBarabash
force-pushed
the
sync_perman_del_acc
branch
11 times, most recently
from
July 15, 2022 19:51
6df80d8
to
989ea5c
Compare
AlexeyBarabash
force-pushed
the
sync_perman_del_acc
branch
2 times, most recently
from
August 19, 2022 19:22
82649bf
to
a557592
Compare
… the [Permanently delete account]
This Brave Sync account was deleted from other device. If you didn’t mean to remove the Sync, _re-create the account_ [OK]
This Brave Sync account was deleted from other device. If you didn’t mean to remove the Sync, _re-create the account_ [OK] introduced BraveSyncAccountDeletedInfoBar class for ConfirmInfoBar customization
Addresses and more => Addresses, payment info, etc. Apps => Web apps (PWAs)
AlexeyBarabash
force-pushed
the
sync_perman_del_acc
branch
from
December 20, 2022 13:09
b89af64
to
de692ee
Compare
samartnik
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This was referenced Jan 27, 2023
25 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#22884
This PR introduces ability to permanently delete the sync chain for desktop and Android.
Related server changes: https://github.com/brave/go-sync/compare/102-add-account-delete
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Pls see #13562 (comment)