Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix account deletion is in progress modal #28105

Closed
AlexeyBarabash opened this issue Jan 27, 2023 · 1 comment · Fixed by brave/brave-core#18746
Closed

Fix account deletion is in progress modal #28105

AlexeyBarabash opened this issue Jan 27, 2023 · 1 comment · Fixed by brave/brave-core#18746
Assignees
@AlexeyBarabash
Labels
bug feature/sync OS/Desktop QA Pass-Win64 QA/Yes regression release-notes/exclude
Milestone
1.57.x - Release

Comments

@AlexeyBarabash
Copy link
Contributor

Follow-up for brave/brave-core#13562
Found while test #22884 (comment)

The screenshot:
image
@AlexeyBarabash AlexeyBarabash self-assigned this Jan 27, 2023
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Jun 2, 2023
@AlexeyBarabash
Fix margins at delete sync account in progress modal; fixes brave/bra…
edce1ed 
…ve-browser#28105
@AlexeyBarabash AlexeyBarabash mentioned this issue Jun 2, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 7, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.57.8 Chromium: 115.0.5790.75 (Official Build) beta (64-bit)
-- | --
Revision | 77bffd419b7e89d7e666c9695e7fa0d1d0367a99
OS | Windows 11 Version 22H2 (Build 22621.1992)
  1. Install 1.57.8
  2. launch Brave
  3. opened brave://sync
  4. setup a sync chain on Profile 1
  5. joined the sync from Profile 2
  6. return to brave://settings/braveSync/setup for Profile 1
  7. scroll down to the bottom and click Delete Sync account
  8. clicked on Permanently delete account on the Delete Sync account dialog

Confirmed margins are fixed around Account deletion is in progress... text area

1.52.130 step 4 step 5 step 7 step 8 1.57.8
image image image image image image

@rebron rebron moved this to Completed in Sync - All platforms Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
bug feature/sync OS/Desktop QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
Sync - All platforms
Status: Completed
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

Fix margins at delete sync account in progress modal brave/brave-core
4 participants
@stephendonner @AlexeyBarabash @brave-builds @MadhaviSeelam