Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing to custom RPC urls for known chains #13480

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented May 26, 2022

Resolves brave/brave-browser#20517

Implemented behind BraveWalletEditKnownNetworks feature

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bbondy
Copy link
Member

bbondy commented May 26, 2022

Possible to post a small video or screenshots of how this looks?

@supermassive supermassive force-pushed the EditKnownChains branch 3 times, most recently from 1b342c4 to d5cd492 Compare May 30, 2022 05:43
@supermassive supermassive added this to the 1.41.x - Nightly milestone May 31, 2022
@supermassive
Copy link
Collaborator Author

supermassive commented May 31, 2022

bandicam.2022-05-31.09-19-41-215.mp4

@bbondy

@supermassive supermassive changed the title [Wip] Allow changing to custom RPC urls for known chains Allow changing to custom RPC urls for known chains May 31, 2022
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but please check if Android is working fine, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow changing to custom RPC urls for known chains (e.g. Flashbots RPC)
3 participants