Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changing to custom RPC urls for known chains (e.g. Flashbots RPC) #20517

Closed
spylogsster opened this issue Jan 15, 2022 · 3 comments · Fixed by brave/brave-core#13480
Closed

Allow changing to custom RPC urls for known chains (e.g. Flashbots RPC) #20517

spylogsster opened this issue Jan 15, 2022 · 3 comments · Fixed by brave/brave-core#13480
Assignees
@supermassive
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.41.x - Release

Comments

@spylogsster
Copy link

spylogsster commented Jan 15, 2022 •
edited by bbondy
Loading

Similar to #21089
But we can probably make this work by allowing known networks to be modified within that same settings page on brave://settings/wallet/networks

https://medium.com/alchemistcoin/how-to-add-flashbots-protect-rpc-to-your-metamask-3f1412a16787
@rebron rebron added the feature/web3/wallet Integrating Ethereum+ wallet support label Jan 26, 2022
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 3, 2022
@bbondy bbondy changed the title Allow to update default networks in the setting Allow changing to custom RPC urls for known chains (e.g. Flashbots RPC) Feb 14, 2022
@bbondy bbondy mentioned this issue Feb 14, 2022
Closed
@jamesmudgett
Copy link

I agree, however for know networks we should have a way to reset(restore) back to original.

@supermassive supermassive mentioned this issue May 26, 2022
Merged
25 tasks
@supermassive supermassive mentioned this issue Jun 2, 2022
Closed
@supermassive
Copy link

Further work is done in #23207

@supermassive supermassive added this to the 1.41.x - Nightly milestone Jun 7, 2022
This was referenced Jun 10, 2022
Closed
Open
@srirambv
Copy link
Contributor

Brave 1.41.82 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13480(comment)
  • Verified able to update/edit RPC URL's
  • Verified able to set edited network as default
  • Verified reset changes the network RPC URL to default value
20517-Linux.mp4
20517-Windows.mp4
20517-macOS.mov

@LaurenWags LaurenWags mentioned this issue Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

Allow changing to custom RPC urls for known chains brave/brave-core
6 participants
@supermassive @jamesmudgett @bbondy @spylogsster @rebron @srirambv