-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favicon and color fixes for Shields v2 #12994
Conversation
93a42ac
to
cd99978
Compare
A Storybook has been deployed to preview UI for the latest push |
@@ -38,6 +38,7 @@ function App () { | |||
const onVisibilityChange = () => { | |||
if (document.visibilityState === 'visible') { | |||
getPanelBrowserAPI().panelHandler.showUI() | |||
getPanelBrowserAPI().dataHandler.updateFavicon() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious only needs explicit favicon update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, internally i'm sending favicon url as site_block_info_.favicon_url
- on an active tab it will send the right url but sometimes resources take time to load and favicon hasn't been downloaded to the disk so OnFavIconUpdate()
the favicon_url will update by cache busting.
However, when opening the panel while it's cached on a new webcontents (tab) it doesn't trigger an update, so dataHandler.updateFavicon()
here helps do that. A non-cached panel can easily get the updated url from site_block_info_
cd99978
to
6974cda
Compare
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
Verified
|
Brave | 1.39.68 Chromium: 101.0.4951.34 (Official Build) nightly (x86_64) |
---|---|
Revision | 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710} |
OS | macOS Version 12.4 (Build 21F5048e) |
Checked:
- Local site favicon is replaced by Brave favicon when clicked Learn more link brave-browser#22214 - confirmed favicon is correctly updated between unique tabs (@MadhaviSeelam 's issue)
- Shields' blocked count gets clipped when 4 or more digits brave-browser#22161 - verified blocked counts 1,000+ (light and dark modes)
- Global defaults inconsistent appearance when Shields are down brave-browser#22217 - confirmed correct default and hovered-state color
- The incorrect site favicon is shown in the shield panel when switching between the two sites brave-browser#22284 - confirmed favicon is correctly updated between unique tabs (@GeetaSarvadnya 's issue)
- update shields down design brave-browser#22283 - verified removal of
"You're viewing this site without Brave's privacy protections."
text and widenedReport site
button
Resolves brave/brave-browser#22214
Resolves brave/brave-browser#22161
Resolves brave/brave-browser#22217
Resolves brave/brave-browser#22284
Resolves brave/brave-browser#22283
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: