Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields' blocked count gets clipped when 4 or more digits #22161

Closed
stephendonner opened this issue Apr 7, 2022 · 3 comments · Fixed by brave/brave-core#12994
Closed

Shields' blocked count gets clipped when 4 or more digits #22161

stephendonner opened this issue Apr 7, 2022 · 3 comments · Fixed by brave/brave-core#12994
Assignees
@nullhook
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.38.x - Release

Comments

@stephendonner
Copy link

Description

Shields' blocked count gets clipped when 4 or more digits

Steps to Reproduce

  1. install 1.39.39
  2. launch Brave
  3. load a site with heavy ads/trackers (Words with Friends, Facebook games, etc.)
  4. click on the 99+ after some time
  5. look at the formatting of the blocked-elements count

Actual result:

Clipping of the 4th digit in the blocked-elements count.

example example
Screen Shot 2022-04-07 at 1 54 32 PM Screen Shot 2022-04-07 at 1 55 50 PM

Expected result:

No clipping of the blocked elements #.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.39 Chromium: 100.0.4896.79 (Official Build) nightly (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 11.6.5 (Build 20G527)

cc @nullhook @Tonev
@stephendonner stephendonner added bug feature/shields The overall Shields feature in Brave. QA/Yes QA/Test-Plan-Specified feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop labels Apr 7, 2022
@rebron
Copy link
Collaborator

rebron commented Apr 12, 2022

cc: @aguscruiz

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Apr 12, 2022
@nullhook nullhook mentioned this issue Apr 12, 2022
Merged
25 tasks
@nullhook nullhook added this to the 1.39.x - Nightly milestone Apr 14, 2022
@kjozwiak
Copy link
Member

Above requires 1.38.102 or higher for 1.38.x verification.

@GeetaSarvadnya
Copy link

Verification PASSED on


Brave | 1.38.103 Chromium: 100.0.4896.127 (Official Build) beta (64-bit)
-- | --
Revision | ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS | Windows 10 Version 21H2 (Build 19044.1645)
  • Verified the STR from the description and ensured blocked trackers count is NOT clipped
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Favicon and color fixes for Shields v2 brave/brave-core
5 participants
@stephendonner @kjozwiak @rebron @nullhook @GeetaSarvadnya