Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled sidebar item bubble status properly after adding item #12369

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 23, 2022

fix brave/brave-browser#21246

After item is added, bubble should be visible if there are item add
candidates. Otherwise, bubble should be closed.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See STR in the linked issue.

@simonhong simonhong requested a review from bsclifton February 23, 2022 01:44
@simonhong simonhong self-assigned this Feb 23, 2022
@simonhong simonhong force-pushed the close_sidebar_item_add_bubble_after_added branch from 830cf83 to 0d0b323 Compare February 23, 2022 07:11
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! And thanks for making the names more clear (and also raw_ptr cleanup) 😄 👍

fix brave/brave-browser#21246

After item is added, bubble should be visible if there are item add
candidates. Otherwise, bubble should be closed.
@simonhong simonhong force-pushed the close_sidebar_item_add_bubble_after_added branch from 0d0b323 to d12809f Compare February 23, 2022 09:00
@simonhong simonhong merged commit 9420aa0 into master Feb 23, 2022
@simonhong simonhong deleted the close_sidebar_item_add_bubble_after_added branch February 23, 2022 10:31
@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar item add bubble state is not handled properly after adding item
2 participants