Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar item add bubble state is not handled properly after adding item #21246

Closed
simonhong opened this issue Feb 23, 2022 · 3 comments · Fixed by brave/brave-core#12369
Closed

Sidebar item add bubble state is not handled properly after adding item #21246

simonhong opened this issue Feb 23, 2022 · 3 comments · Fixed by brave/brave-core#12369
Assignees
@simonhong
Labels
bug feature/sidebar Relating to Brave's Sidebar feature OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.37.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Feb 23, 2022 •
edited
Loading

Item add bubble should not be closed if there are adding candidates after adding items.

STR 1 - bubble has empty area after adding item

  1. Start with default sidebar items list
  2. Remove bookmarks sidebar item
  3. Load www.brave.com at current active tab
  4. Mouse over the add button
  5. Add brave.com to sidebar
  6. Bubble should not have empty area

image

STR 2 - add item bubble is closed

  1. Start with default sidebar items list
  2. Remove bookmarks sidebar item
  3. Load www.brave.com at current active tab
  4. Mouse over the add button
  5. Add bookmarks sidebar
  6. Bubble should not be hidden and bubble has brave.com item
@simonhong simonhong self-assigned this Feb 23, 2022
@simonhong simonhong mentioned this issue Feb 23, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Feb 23, 2022
@simonhong
Handled sidebar item bubble status properly after adding item
d12809f 
fix brave/brave-browser#21246

After item is added, bubble should be visible if there are item add
candidates. Otherwise, bubble should be closed.
@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 23, 2022
@stephendonner
Copy link

stephendonner commented Feb 23, 2022 •
edited
Loading

Verified PASSED using

Brave 1.37.67 Chromium: 99.0.4844.35 (Official Build) nightly (x86_64)
Revision f60a827ddb87f1c403e07713751a5551d5856ac0-refs/branch-heads/4844@{#579}
OS macOS Version 12.3 (Build 21E5222a)

Case 1: Bubble has empty area after adding item

Steps:

  1. Start with default sidebar items list
  2. Remove bookmarks sidebar item
  3. Load http://www.brave.com at current active tab
  4. Mouse over the add (+) button
  5. Add brave.com to sidebar
  6. Bubble should not have empty area

Confirmed there's no empty space in the Add to Sidebar bubble

example example example example
Screen Shot 2022-02-23 at 3 24 46 PM Screen Shot 2022-02-23 at 3 22 41 PM Screen Shot 2022-02-23 at 3 25 09 PM Screen Shot 2022-02-23 at 3 24 17 PM

Case 2: Add to Sidebar is closed

Steps:

  1. Start with default sidebar items list
  2. Remove bookmarks sidebar item
  3. Load brave.com at current active tab
  4. Mouse over the add (+) button
  5. Add bookmarks to sidebar
  6. Bubble should not be hidden and bubble has brave.com item

Confirmed the bubble appears and has an Add to Sidebar item for brave.com

example example example example
Screen Shot 2022-02-23 at 3 24 46 PM Screen Shot 2022-02-23 at 3 24 59 PM Screen Shot 2022-02-23 at 3 25 05 PM Screen Shot 2022-02-23 at 3 24 17 PM

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 8, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 9, 2022 •
edited
Loading

Brave 1.37.84 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Windows 11 Version 21H2 (Build 22000.493)

Testcase 1: Add to Sidebar bubble shouldn't have empty area after adding item

  • Install 1.37.x
  • Launch Brave
  • Start with default sidebar items list
  • Remove bookmarks sidebar item from default sidebar items list
  • Load brave.com at current active tab
  • Mouse over the add (+) button
  • Add brave.com to sidebar
  • Bubble should not have empty area
  • Verified that there's no empty space in the Add to Sidebar bubble
Default_sidebar Remove_bookmarks Load_brave Mouse_over Sidebar
bookmarks sidebar removedbookmarks load brave mouseovertheaddbutton addbravetosidebar

Testcase 2: Add to Sidebar is displayed

  • Fresh profile
  • Launch Brave
  • Start with default sidebar items list
  • Remove bookmarks sidebar item from default sidebar items list
  • Load brave.com at current active tab
  • Mouse over the add (+) button
  • Add bookmarks to sidebar
  • Bubble should not be hidden and bubble has brave.com item
  • Verified that bubble appears and has an 'Add to Sidebar' for brave.com
Default_sidebar Remove_bookmarks Load_brave Mouse_over Sidebar
default_sidebar_item_list Remove_bookmarks load_brave mouse over Screenshot 2022-03-09 091758

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 9, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.37.95 Chromium: 99.0.4844.74 (Official Build) beta (64-bit)
Revision fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Case 1: Bubble has empty area after adding item

Confirmed there's no empty space in the Add to Sidebar bubble

image
image
image
image

Case 2: Add to Sidebar is closed

Steps:

  1. Start with default sidebar items list
  2. Remove bookmarks sidebar item
  3. Load brave.com at current active tab
  4. Mouse over the add (+) button
  5. Add bookmarks to sidebar
  6. Bubble should not be hidden and bubble has brave.com item

Confirmed the bubble appears and has an Add to Sidebar item for brave.com

image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/sidebar Relating to Brave's Sidebar feature OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Handled sidebar item bubble status properly after adding item brave/brave-core
5 participants
@stephendonner @simonhong @LaurenWags @btlechowski @MadhaviSeelam