Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gethostname to setup default device name #1223

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Use gethostname to setup default device name #1223

merged 1 commit into from
Jan 7, 2019
+50 −51

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Jan 4, 2019 •
edited
Loading

Use gethostname to setup default device name

this is needed by Sync but only made up to 0.60.x. ref #1136 (comment)

@darkdh @cezaraugusto
Merge pull request #1136 from brave/sync-hostname
ba02f2d 
Use `gethostname` to setup default device name
@cezaraugusto cezaraugusto self-assigned this Jan 4, 2019
@cezaraugusto cezaraugusto mentioned this pull request Jan 4, 2019
Merged
18 tasks
@cezaraugusto cezaraugusto changed the title Merge pull request #1136 from brave/sync-hostname Use gethostname to setup default device name Jan 4, 2019
kjozwiak
kjozwiak approved these changes Jan 5, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.59.x approved after deliberating with @rebron 👍 Please make sure that the associated issues are also moved into the correct milestone.

@cezaraugusto cezaraugusto merged commit 9508cb9 into 0.59.x Jan 7, 2019
@cezaraugusto cezaraugusto deleted the ca-sync-1136-59 branch January 7, 2019 15:11
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@cezaraugusto cezaraugusto

Labels
feature/sync
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@cezaraugusto @kjozwiak @bbondy @darkdh