Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gethostname to setup default device name #1136

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Use gethostname to setup default device name #1136

merged 1 commit into from
Dec 20, 2018

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Dec 19, 2018 •
edited
Loading

If we allow users to customize device name, just pass what they input to
the API. Otherwise, just pass empty string.

fix brave/brave-browser#2573

screen shot 2018-12-18 at 20 57 28

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Create sync chain on device A
  2. Connect device B to the sync chain
  3. The device list should show hostname of the device

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@darkdh darkdh self-assigned this Dec 19, 2018
@darkdh
Copy link
Member Author

darkdh commented Dec 19, 2018

building on other platforms to make sure build and test passed

@darkdh
Copy link
Member Author

darkdh commented Dec 19, 2018

builds and tests passed on all platforms

AlexeyBarabash
AlexeyBarabash previously approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@darkdh
Use gethostname to setup default device name
5ede720 
If we allow users to customize device name, just pass what they input to
the API. Otherwise, just pass empty string.
@darkdh
Copy link
Member Author

darkdh commented Dec 19, 2018

rebased.

@darkdh darkdh merged commit 73234e9 into master Dec 20, 2018
darkdh added a commit that referenced this pull request Dec 20, 2018
@darkdh
Merge pull request #1136 from brave/sync-hostname
f51ab2c 
Use `gethostname` to setup default device name
@darkdh
Copy link
Member Author

darkdh commented Dec 20, 2018 •
edited by cezaraugusto
Loading

master: 73234e9
0.60.x: f51ab2c
0.59.x 9508cb9

@darkdh darkdh deleted the sync-hostname branch December 20, 2018 01:38
@cezaraugusto cezaraugusto mentioned this pull request Dec 20, 2018
Closed
cezaraugusto pushed a commit that referenced this pull request Jan 4, 2019
@darkdh @cezaraugusto
Merge pull request #1136 from brave/sync-hostname
ba02f2d 
Use `gethostname` to setup default device name
@cezaraugusto cezaraugusto mentioned this pull request Jan 4, 2019
Merged
@cezaraugusto
Copy link
Contributor

pr requesting uplift to 0.59.x at #1223

@cezaraugusto cezaraugusto mentioned this pull request Jan 4, 2019
Merged
@cezaraugusto
Copy link
Contributor

0.59.x 9508cb9

@bbondy bbondy added this to the 0.60.x - Dev milestone Jan 14, 2019
NejcZdovc pushed a commit that referenced this pull request Sep 19, 2019
@ryanml @NejcZdovc
Rewards: Imported from brave-ui: Android fixes (#1136, #1018, #1004, #…
eabb47f 
…1147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@AlexeyBarabash AlexeyBarabash AlexeyBarabash left review comments

Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
0.60.x - Release
Development

Successfully merging this pull request may close these issues.

Use host name for default sync device name
4 participants
@darkdh @cezaraugusto @AlexeyBarabash @bbondy