Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing to IPNS should be in separate menu #12160

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 6, 2022

Resolves brave/brave-browser#16998

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Import items in the app menu should not be visible if local node is not selected as resolution method and not launched
  • IPNS keys items should not be visible if ipns keys are empty in the service
  • all import actions should work as expected

@spylogsster spylogsster changed the title Publishing to IPNS should be in separate menu WIP: Publishing to IPNS should be in separate menu Feb 6, 2022
@spylogsster spylogsster self-assigned this Feb 6, 2022
@spylogsster spylogsster force-pushed the issue-16998 branch 6 times, most recently from 49bd482 to 094bde9 Compare February 8, 2022 16:16
@spylogsster spylogsster changed the title WIP: Publishing to IPNS should be in separate menu Publishing to IPNS should be in separate menu Feb 8, 2022
@spylogsster spylogsster marked this pull request as ready for review February 8, 2022 16:21
browser/ui/brave_browser_command_controller.cc Outdated Show resolved Hide resolved
browser/ui/browser_commands.h Show resolved Hide resolved
@@ -14,7 +14,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/grit/generated_resources.h"

#if BUILDFLAG(ENABLE_IPFS)
#if BUILDFLAG(ENABLE_IPFS_LOCAL_NODE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for changing all flags from ENABLE_IPFS to ENABLE_IPFS_LOCAL_NODE in this PR?

Copy link
Contributor Author

@spylogsster spylogsster Feb 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ipfs related code in this file works only when ipfs local node is up. We added ENABLE_IPFS_LOCAL_NODE later than this code and I changed it now to have correct build flag

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spylogsster spylogsster merged commit 29b2e77 into master Feb 8, 2022
@spylogsster spylogsster deleted the issue-16998 branch February 8, 2022 21:41
@spylogsster spylogsster added this to the 1.37.x - Nightly milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publishing to IPNS should be in separate menu
3 participants