-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishing to IPNS should be in separate menu #16998
Comments
Update: we should go with a simplified menu that prioritizes sharing of immutable snapshots and hides IPNS options a bit. Rationale: In most cases, IPNS is not what you want to do, and we should not overwhelm new users with too many options.
This way user can Import and share files, and also has an option to get back to the Files screen with ease at any point. |
Verified
|
Brave | 1.37.40 Chromium: 98.0.4758.87 (Official Build) nightly (x86_64) |
---|---|
Revision | e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002} |
OS | macOS Version 11.6.1 (Build 20G224) |
Case 1: publish with local node
- install
1.37.40
- launch Brave
- load
ipns://ipfs.io
- click
Use a Brave local IPFS node
- click the 3-dots menu
- click on
Import and Share a File
- click on
Import and Share a Directory
- click on
Open Files
- click on
Update IPNS
->With a File
->self {key}
10.click onUpdate IPNS
->With a Directory
->self {key}
Import and Share
(File
, Directory
)
file | file | directory | directory |
---|---|---|---|
Open Files
example | example |
---|---|
Update IPNS
with (File
, Directory
)
file | file | directory | directory |
---|---|---|---|
Case Two: IPFS flyout menu
- install
1.37.40
- launch Brave
- click on the
"hamburger"
menu - confirmed there is no
IPFS
flyout menu - load
brave://ipfs-internals/
- click
Use a Brave local IPFS node
- open
brave://settings/ipfs
- choose any one of the
Ask
,Gateway
,Disabled
options underMethod to resolve IPFS resources
- click on the
"hamburger"
menu again - confirm you now see the
IPFS
flyout menu item
default | ask / gateway / disabled |
Brave-local IPFS node enabled |
---|---|---|
Verified PASSED
using
Brave | 1.37.89 Chromium: 99.0.4844.51 (Official Build) beta (64-bit) |
---|---|
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875} |
OS | Windows 10 Version 21H2 (Build 19044.1586) |
Case 1: publish with local node
- install
1.37.89
- launch Brave
- load
ipns://ipfs.io
- click
Use a Brave local IPFS node
- click the 3-dots menu
- click on
Import and Share a File
- click on
Import and Share a Directory
- click on
Open Files
- click on
Update IPNS
->With a File
->self {key}
10.click onUpdate IPNS
->With a Directory
->self {key}
Import and Share
(File
, Directory
)
file | file | directory | directory |
---|---|---|---|
Open Files
example | example |
---|---|
Update IPNS
with (File
, Directory
)
file | file | directory | directory |
---|---|---|---|
Case Two: IPFS flyout menu
- install
1.37.40
- launch Brave
- click on the
"hamburger"
menu - confirmed there is no
IPFS
flyout menu - load
brave://ipfs-internals/
- click
Use a Brave local IPFS node
- open
brave://settings/ipfs
- choose any one of the
Ask
,Gateway
,Disabled
options underMethod to resolve IPFS resources
- click on the
"hamburger"
menu again - confirm you now see the
IPFS
flyout menu item
default | ask / gateway / disabled |
Brave-local IPFS node enabled |
---|---|---|
Verification passed on
Brave | 1.37.101 Chromium: 99.0.4844.83 (Official Build) beta (64-bit) |
---|---|
Revision | b11086e62d7c1a44b0942ac5568d22a425c7ae35-refs/branch-heads/4844_74@{#5} |
OS | Ubuntu 20 LTS |
Case 1: publish with local node
- install Brave
- launch Brave
- load
ipns://ipfs.io
- click
Use a Brave local IPFS node
- click the 3-dots menu
- click on
Import and Share a File
- click on
Import and Share a Directory
- click on
Open Files
- click on
Update IPNS
->With a File
->self {key}
10.click onUpdate IPNS
->With a Directory
->self {key}
Import and Share
(File
, Directory
)
file | file | directory | directory |
---|---|---|---|
Open Files
example | example |
---|---|
Update IPNS
with (File
, Directory
)
file | file | directory | directory |
---|---|---|---|
Case Two: IPFS flyout menu
- install Brave
- launch Brave
- click on the
"hamburger"
menu - confirmed there is no
IPFS
flyout menu - load
ipns://ipfs.io
- click
Use a Brave local IPFS node
- open
brave://settings/ipfs
- choose any one of the
Ask
,Gateway
,Disabled
options underMethod to resolve IPFS resources
- click on the
"hamburger"
menu again - confirm you now see the
IPFS
flyout menu item
default | ask / gateway / disabled |
Brave-local IPFS node enabled |
---|---|---|
UX Problem
There is confusing inconsistency in sharing menu.
By default, we show simple actions for sharing IPFS CIDs:
Note there is no way to share over IPNS (which IMO is a bug, because
self
key is always present).To enable IPNS sharing, one needs to go to settings and click on "Set up IPNS keys":
You dont need to add any, just open it. There is
self
key by default.After that, a confusing submenu is presented in the main menu:
It has problematic UX → the most common use case (sharing static IPFS CID) is buried 2 levels deep, and users most likely will abandon interaction or pick IPNS without fully understanding it is mutable publishing.
Proposed fix
I believe submenu is too confusing.
Instead, we should have IPNS in the top menu:
The text was updated successfully, but these errors were encountered: