Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Assets Panel View #11886

Merged
merged 1 commit into from
Jan 19, 2022
Merged

feat(wallet): Assets Panel View #11886

merged 1 commit into from
Jan 19, 2022

Conversation

Douglashdaniel
Copy link
Contributor

Description

Assets Panel View

Before we had a scroll into view feature to see your selected accounts assets in the Main wallet panel.
We have now separated assets out into its own view.

Resolves brave/brave-browser#20464

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Before:

Screen.Recording.2022-01-18.at.12.52.14.PM.mov

After:

Screen.Recording.2022-01-18.at.12.39.35.PM.mov

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner January 18, 2022 19:53
@Douglashdaniel Douglashdaniel self-assigned this Jan 18, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 18, 2022
Copy link
Contributor

@muliswilliam muliswilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary scroll bar on panel. Also causes buttons to lose left padding
4 participants