Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary scroll bar on panel. Also causes buttons to lose left padding #20464

Closed
srirambv opened this issue Jan 12, 2022 · 1 comment · Fixed by brave/brave-core#11886
Closed
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop OS/Linux OS/Windows polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Unnecessary scroll bar on panel. Also causes buttons to lose left padding

Steps to Reproduce

  1. Install nightly
  2. Open a site and open Wallet panel
  3. Triggers OCD after seeing the horrible scrollbars

Actual result:

Linux Windows macOS
)

Expected result:

Only show scroll bar when its required to scroll similar to macOS

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.36.31 Chromium: 97.0.4692.71 (Official Build) nightly (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Linux / Windows

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @jamesmudgett @Douglashdaniel

@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks OS/Linux OS/Windows QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jan 12, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jan 12, 2022
@Douglashdaniel Douglashdaniel added this to the 1.36.x - Nightly milestone Jan 19, 2022
@srirambv
Copy link
Contributor Author

Brave 1.36.93 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11886
  • Verified no unnecessary scroll bar on panel when loading the panel
  • Encountered issue where 0 balance tokens/coins causes it to be slow to list it but that should be fixed as part of #20955
20464-Linux.mp4
20464-Windows.mov
20464-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop OS/Linux OS/Windows polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants