Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change spelling from 'Github' to 'GitHub' in brave://settings/rewards #11719

Merged

Conversation

richorrichard
Copy link
Contributor

@richorrichard richorrichard commented Dec 30, 2021

My first contribution!

Resolves brave/brave-browser#19155

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@richorrichard
Copy link
Contributor Author

I updated the main app/resources/brave_generated_resources.grd file, but I also found that there were references to the incorrect Github spelling in all of the translation files inside the app/resources folder. I'm not familiar enough with the build to know if those are files I should also update, in which case I can easily do that. Please advise!

@mihaiplesa mihaiplesa merged commit 7cb4ea0 into brave:master Jan 26, 2022
@bsclifton
Copy link
Member

Nice one- thanks @richorrichard 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github should be spelled GitHub on brave://settings/rewards
3 participants