Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github should be spelled GitHub on brave://settings/rewards #19155

Closed
stephendonner opened this issue Nov 2, 2021 · 10 comments · Fixed by brave/brave-core#11719
Closed

Github should be spelled GitHub on brave://settings/rewards #19155

stephendonner opened this issue Nov 2, 2021 · 10 comments · Fixed by brave/brave-core#11719

Comments

@stephendonner
Copy link

Description

Github should be spelled GitHub on brave://settings/rewards

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load brave://settings/rewards
  4. look at the spelling of GitHub

Actual result:

Github (note the lower-case h)

Screen Shot 2021-11-01 at 5 29 50 PM

Expected result:

GitHub (note the capital H)

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.33.50 Chromium: 95.0.4638.69 (Official Build) nightly (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.6.1 (Build 20G224)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@lpizzinidev
Copy link

Hi! Can I work on this issue?

@bsclifton
Copy link
Member

@lpizzinidev please do! 😄

@coder-abhi
Copy link

What is the status of this issue?
Assign it to me if possible.

@lpizzinidev
Copy link

@bsclifton I'm currently working on other projects and I didn't have time to check this out.
You could assign this to @coder-abhi if you wish.

@bsclifton bsclifton assigned coder-abhi and unassigned lpizzinidev Nov 12, 2021
@bsclifton
Copy link
Member

done 😄 @coder-abhi let me know if you have any questions

@coder-abhi
Copy link

Hello @bsclifton . help me out with this error i get while building on local machine
brave-installation issue

@bsclifton
Copy link
Member

bsclifton commented Nov 12, 2021

@coder-abhi ah - this is a bug we have which is not solved unfortunately. Some commentary about it here:
#13631

Basically, you should be able to downgrade your npm version in order to work past this. For example, you can install 6.14.11

I'll create an official issue for this because it's a bit embarrassing having to use an old NPM to work-around this
edit: created #19398 to track

@amit-2000
Copy link

is this issue still open?

@stephendonner
Copy link
Author

is this issue still open?

@amit-2000 hi, yes, the pull request is still open too: brave/brave-core#11719. That'll need to get reviewed and landed, before we close this out and verify it.

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.36.73 Chromium: 98.0.4758.66 (Official Build) nightly (x86_64)
Revision db1b4001d5ce29f141297f260d2b778e000b85a3-refs/branch-heads/4758@{#762}
OS macOS Version 12.2 (Build 21D48)

Confirmed it's spelled GitHub now in brave://settings/rewards.

Screen Shot 2022-01-26 at 5 46 26 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment