Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add favicon to the welcome page #1118

Merged
merged 1 commit into from
Dec 20, 2018
Merged

add favicon to the welcome page #1118

merged 1 commit into from
Dec 20, 2018

Conversation

rossmoody
Copy link
Contributor

Had a revert where the Welcome page favicon went missing. This repairs it.

Fixes brave/brave-browser#2611

@rossmoody rossmoody self-assigned this Dec 17, 2018
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 09f767b into master Dec 20, 2018
@cezaraugusto cezaraugusto deleted the welcome-favico-2 branch December 20, 2018 14:43
@bbondy
Copy link
Member

bbondy commented Dec 20, 2018

This is only needed for 0.61.x?

@bbondy
Copy link
Member

bbondy commented Dec 20, 2018

adding merge label and associated milestone, but pls do that when merging.

cezaraugusto added a commit that referenced this pull request Jan 6, 2019
@cezaraugusto cezaraugusto mentioned this pull request Jan 6, 2019
18 tasks
cezaraugusto added a commit that referenced this pull request Jan 6, 2019
@cezaraugusto cezaraugusto mentioned this pull request Jan 6, 2019
18 tasks
@cezaraugusto cezaraugusto changed the title Repair Welcome Favico add favicon to the welcome page Jan 7, 2019
@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants