Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lost the Welcome Page favicon #2611

Closed
rossmoody opened this issue Dec 17, 2018 · 3 comments
Closed

Lost the Welcome Page favicon #2611

rossmoody opened this issue Dec 17, 2018 · 3 comments
Assignees
@rossmoody
Labels
about-pages/welcome QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@rossmoody
Copy link
Contributor

Lost the favicon with the new welcome page update.

image
@rossmoody rossmoody self-assigned this Dec 17, 2018
@rossmoody rossmoody mentioned this issue Dec 17, 2018
Merged
@bbondy bbondy added this to the 0.61.x - Nightly milestone Dec 20, 2018
@rossmoody rossmoody mentioned this issue Jan 3, 2019
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Jan 4, 2019

@bbondy @rebron should we uplift this into 0.59.x as it's a regression? Granted, it's really not that noticeable but seems like a simple thing to uplift so we don't regress under 0.59.x when released. Example:

screen shot 2019-01-04 at 1 35 29 am

Top one belongs to 0.58.18 Chromium: 71.0.3578.98 (Official Build) which is the current release.

@bbondy
Copy link
Member

bbondy commented Jan 4, 2019

sgtm

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 8, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 10

Verification passed on

image

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossmoody rossmoody

Labels
about-pages/welcome QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

No branches or pull requests
7 participants
@bbondy @kjozwiak @cezaraugusto @rebron @srirambv @rossmoody @GeetaSarvadnya