Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text for enabling Rewards from brave://settings/rewards #11158

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Nov 18, 2021

Resolves brave/brave-browser#19496

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick self-assigned this Nov 18, 2021
@emerick emerick requested a review from zenparsing November 18, 2021 19:09
@emerick emerick added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Nov 18, 2021
@emerick
Copy link
Contributor Author

emerick commented Nov 18, 2021

CI passed on all platforms except Linux; restarting for Linux.

@emerick emerick force-pushed the rewards-brave-settings-enable-rewards-text branch from f4f9396 to 2e39984 Compare November 18, 2021 23:20
@emerick emerick removed CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows CI/skip-ios Do not run CI builds for iOS labels Nov 19, 2021
@emerick
Copy link
Contributor Author

emerick commented Nov 19, 2021

Linux CI passed; ready for merge.

@emerick emerick merged commit a8a2963 into master Nov 19, 2021
@emerick emerick deleted the rewards-brave-settings-enable-rewards-text branch November 19, 2021 00:40
@emerick emerick added this to the 1.34.x - Nightly milestone Nov 19, 2021
brave-builds pushed a commit that referenced this pull request Nov 19, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Nov 22, 2021

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.34.25 Chromium: 96.0.4664.45 (Official Build) nightly (64-bit)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | Windows 11 Version 21H2 (Build 22000.318)
Text Change Opening rewards panel Rewards Enabled
newText openingPanel rewardsEnabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing hyperlinks for Brave rewards under Settings
3 participants