Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing hyperlinks for Brave rewards under Settings #19496

Closed
GeetaSarvadnya opened this issue Nov 16, 2021 · 4 comments · Fixed by brave/brave-core#11158
Closed

Missing hyperlinks for Brave rewards under Settings #19496

GeetaSarvadnya opened this issue Nov 16, 2021 · 4 comments · Fixed by brave/brave-core#11158

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 16, 2021

Description

Brave Rewards are disabled text and Click here to learn more link are not showing up as mentioned in #18158

Steps to Reproduce

  1. Clean profile 1.33.80
  2. Navigate to brave://settings/rewards
  3. Click on Brave Rewards are disabled text
  4. Rewards onboarding modal popup is displayed
  5. Brave Rewards are disabled text and Click here to learn more link should work/shown as mentioned in the description Implement Rewards settings section inside brave://settings #18158 (comment)

Actual result:

  • Click here to learn more is not showing up as a link
  • Brave Rewards are disabled text and Click here to learn more link are shown in two lines instead of a single line
    image

Expected result:

  • Click here to learn more should be displayed as a link
  • Brave Rewards are disabled text and Click here to learn more link should be displayed in the single line
  • Brave Rewards are disabled text should not show as a clickable

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.33.80 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 21H1 (Build 19043.1348)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @Miyayes @emerick

@GeetaSarvadnya GeetaSarvadnya changed the title Brave Rewards are disabled text and Click here to learn more link are not showing up as mentioned in #18158 Missing hyperlinks for Brave rewards under Settings Nov 16, 2021
@emerick
Copy link
Contributor

emerick commented Nov 16, 2021

@GeetaSarvadnya I think the idea there is that clicking to "learn more" pops up the Rewards panel which explains how Rewards works, etc. I don't think it's meant to be its own separate link, but cc: @Miyayes in case I have that wrong.

@Miyayes
Copy link
Collaborator

Miyayes commented Nov 16, 2021

Yes, I remember from @jamesmudgett that it's supposed to pop open the Rewards dropdown panel.

@zenparsing zenparsing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 17, 2021
@zenparsing zenparsing added this to the 1.33.x - Beta milestone Nov 17, 2021
@Miyayes
Copy link
Collaborator

Miyayes commented Nov 17, 2021

Ryan McFadden suggests using: Open Rewards panel to enable and get started. Avoiding "Click" language for accessibility reasons. cc: @rebron Let's go with that.

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Nov 30, 2021

Verification passed on

Brave | 1.33.94 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | Windows 10 Version 21H2 (Build 19044.1387)

Text Change Opening rewards panel Rewards Enabled
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment