Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed error message for the Trezor bridge error #10977

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Nov 10, 2021

Resolves brave/brave-browser#19351

  • Changed error message for the Trezor bridge

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Connect Trezor and go to add account
  2. Click on Trezor to make the popup tab to show up to export private keys
  3. Close the popup tab and go back to wallet, shows error which doesn't make sense

@spylogsster spylogsster self-assigned this Nov 10, 2021
@bbondy bbondy added the not-mvp label Nov 10, 2021
@spylogsster spylogsster merged commit 3a232a9 into master Nov 10, 2021
@spylogsster spylogsster deleted the issue-19351 branch November 10, 2021 19:23
@spylogsster spylogsster added this to the 1.34.x - Nightly milestone Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show meaningful message when Trezor is not connected
2 participants