Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show meaningful message when Trezor is not connected #19351

Closed
srirambv opened this issue Nov 10, 2021 · 1 comment · Fixed by brave/brave-core#10977
Closed

Show meaningful message when Trezor is not connected #19351

srirambv opened this issue Nov 10, 2021 · 1 comment · Fixed by brave/brave-core#10977
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support not-mvp OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Show meaningful message when Trezor is not connected

Steps to Reproduce

  1. Connect Trezor and go to add account
  2. Click on Trezor to make the popup tab to show up to export private keys
  3. Close the popup tab and go back to wallet, shows error which doesn't make sense

Actual result:

image

Expected result:

Show meaningful message for errors

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.95 Chromium: 95.0.4638.69 (Official Build) beta (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc; @jamesmudgett @spylogsster

@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 10, 2021
@bbondy bbondy added the not-mvp label Nov 10, 2021
@spylogsster spylogsster self-assigned this Nov 10, 2021
@spylogsster spylogsster added this to the 1.34.x - Nightly milestone Nov 10, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 4, 2021
@srirambv
Copy link
Contributor Author

srirambv commented Jan 4, 2022

Brave 1.34.77 Chromium: 97.0.4692.56 (Official Build) (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21A559)
  • Verified steps from issue description
  • Verified error message is updated. Confirmed with @spylogsster about the updated message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support not-mvp OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants