Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show correct notice on tipping banner for unregistered creators (uplift to 1.31.x) #10271

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Show correct notice on tipping banner for unregistered creators (uplift to 1.31.x) #10271

merged 2 commits into from
Sep 30, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 27, 2021 •
edited by kjozwiak
Loading

Uplift of #10137
Uplift of #10242

Resolves brave/brave-browser#18137
Resolves brave/brave-browser#18341

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 27, 2021 16:01
@brave-builds brave-builds requested review from jumde, emerick and a team and removed request for a team September 27, 2021 16:01
@brave-builds brave-builds self-assigned this Sep 27, 2021
@brave-builds brave-builds added this to the 1.31.x - Beta milestone Sep 27, 2021
@zenparsing zenparsing force-pushed the pr10137_ksmith-tip-banner-notice_1.31.x branch from 22900ba to f7c34c8 Compare September 29, 2021 19:47
@kjozwiak
Copy link
Member

kjozwiak commented Sep 30, 2021 •
edited
Loading

@LaurenWags is currently working with @zenparsing re: the above. We'll remove PR/Blocked once @LaurenWags mentions that it has been verified and good to merge into 1.31.x.

LaurenWags
LaurenWags approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment •
edited by kjozwiak
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.31.x is approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #10137 (comment) & #10242 (comment).

@LaurenWags LaurenWags merged commit 9446af4 into 1.31.x Sep 30, 2021
@LaurenWags LaurenWags deleted the pr10137_ksmith-tip-banner-notice_1.31.x branch September 30, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

@jumde jumde Awaiting requested review from jumde

@emerick emerick Awaiting requested review from emerick

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging this pull request may close these issues.
5 participants
@brave-builds @kjozwiak @LaurenWags @brave-browser-releases @zenparsing