Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show tipping notice for unverified rewards user case #18341

Closed
zenparsing opened this issue Sep 24, 2021 · 2 comments · Fixed by brave/brave-core#10242
Closed

Do not show tipping notice for unverified rewards user case #18341

zenparsing opened this issue Sep 24, 2021 · 2 comments · Fixed by brave/brave-core#10242
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.31.x - Release

Comments

@zenparsing
Copy link

Follow up to #18137

Users should see an "tipping warning" in both the rewards panel and on the tip dialog in the following case:

  • The user does not have a connected external wallet.
  • The publisher is registered but does not have a verified wallet address.

If the user is unverified, then as long as the creator has a blue checkmark, they'll be able to tip/a path exists from user to creator.
@zenparsing zenparsing mentioned this issue Sep 24, 2021
Merged
24 tasks
@stephendonner stephendonner added this to the 1.32.x - Nightly milestone Sep 24, 2021
@zenparsing zenparsing mentioned this issue Sep 29, 2021
Merged
7 tasks
@LaurenWags
Copy link
Member

LaurenWags commented Oct 4, 2021 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave | 1.31.70 Chromium: 94.0.4606.71 (Official Build) beta (x86_64)
-- | --
Revision | 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS | macOS Version 10.15.7 (Build 19H1417)

Verified test plan from brave/brave-core#10242 (comment)

Scenario 1 - Not registered - PASSED

Confirmed message 1 is displayed on the tipping banner

Example Example
Screen Shot 2021-10-04 at 9 54 07 AM Screen Shot 2021-10-04 at 9 54 15 AM
Scenario 2 - Registered but not verified, user not verified - PASSED

Confirmed no message is displayed about publisher status

Example Example
Screen Shot 2021-10-04 at 9 57 09 AM Screen Shot 2021-10-04 at 9 57 17 AM
Scenario 3 - Registered but not verified, user verified - PASSED

Confirmed message 2 is displayed about publisher status

Example Example
Screen Shot 2021-10-04 at 10 00 27 AM Screen Shot 2021-10-04 at 10 00 36 AM
Scenario 4 - Verified and user is not connected - PASSED

Confirmed no message is displayed about publisher status

Example Example
Screen Shot 2021-10-04 at 10 06 09 AM Screen Shot 2021-10-04 at 10 06 18 AM
Scenario 5 - Verified with non-matching wallet provider - PASSED

Confirmed message 2 is displayed about publisher status

Example Example
Screen Shot 2021-10-04 at 10 09 20 AM Screen Shot 2021-10-04 at 10 09 28 AM
Scenario 6 - Verified with matching wallet provider - PASSED

Confirmed no message is displayed about publisher status

Example Example
Screen Shot 2021-10-04 at 10 10 21 AM Screen Shot 2021-10-04 at 10 10 29 AM

Additional checks performed:

Anon wallet (funded via UGP grant) - PASSED

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

Example Example Example Example
Screen Shot 2021-10-04 at 10 48 28 AM Screen Shot 2021-10-04 at 10 48 36 AM Screen Shot 2021-10-04 at 10 48 50 AM Screen Shot 2021-10-04 at 10 48 56 AM

Confirmed able to tip connected, Uphold, Gemini, and bitFlyer KYC'd creators and no messaging was displayed.
Confirmed balance decreased as expected for tip to each of these creators.

Connected Example Connected Example Uphold Example Uphold Example Gemini Example Gemini Example bitFlyer Example bitFlyer Example Tips List Wallet Panel
Screen Shot 2021-10-04 at 11 04 41 AM Screen Shot 2021-10-04 at 11 04 51 AM Screen Shot 2021-10-04 at 11 05 08 AM Screen Shot 2021-10-04 at 11 05 16 AM Screen Shot 2021-10-04 at 11 05 32 AM Screen Shot 2021-10-04 at 11 05 43 AM Screen Shot 2021-10-04 at 11 06 06 AM Screen Shot 2021-10-04 at 11 06 16 AM Screen Shot 2021-10-04 at 11 06 27 AM Screen Shot 2021-10-04 at 11 06 33 AM
Uphold wallet (funded via Uphold BAT on staging env) - PASSED

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

Example Example Example Example
Screen Shot 2021-10-04 at 10 26 13 AM Screen Shot 2021-10-04 at 10 26 21 AM Screen Shot 2021-10-04 at 10 26 31 AM Screen Shot 2021-10-04 at 10 26 37 AM

Confirmed tip to connected, Gemini, and bitFlyer creators went to pending list and appropriate message (2) was displayed:

Connected Example Connected Example Gemini Example Gemini Example bitFlyer Example bitFlyer Example Wallet Panel Pending Tips List
Screen Shot 2021-10-04 at 10 31 03 AM Screen Shot 2021-10-04 at 10 31 12 AM Screen Shot 2021-10-04 at 10 31 28 AM Screen Shot 2021-10-04 at 10 31 38 AM Screen Shot 2021-10-04 at 10 32 02 AM Screen Shot 2021-10-04 at 10 32 12 AM Screen Shot 2021-10-04 at 10 32 26 AM Screen Shot 2021-10-04 at 10 32 33 AM

Confirmed able to tip Uphold KYC'd creator and no messaging was displayed.
Confirmed balance decreased as expected for tip.

Example Example Example Example
Screen Shot 2021-10-04 at 10 34 13 AM Screen Shot 2021-10-04 at 10 34 25 AM Screen Shot 2021-10-04 at 10 35 06 AM Screen Shot 2021-10-04 at 10 35 37 AM
bitFlyer wallet (funded via bitFlyer BAT on staging env) - PASSED

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

Example Example Example Example
Screen Shot 2021-10-04 at 11 11 15 Screen Shot 2021-10-04 at 11 11 24 Screen Shot 2021-10-04 at 11 11 32 Screen Shot 2021-10-04 at 11 11 39

Confirmed tip to connected, Gemini, and Uphold creators went to pending list and appropriate message (2) was displayed:

Connected Example Connected Example Gemini Example Gemini Example Uphold Example Uphold Example Wallet Panel Pending Tips List
Screen Shot 2021-10-04 at 11 12 03 Screen Shot 2021-10-04 at 11 12 10 Screen Shot 2021-10-04 at 11 12 25 Screen Shot 2021-10-04 at 11 12 34 Screen Shot 2021-10-04 at 11 12 50 Screen Shot 2021-10-04 at 11 12 57 Screen Shot 2021-10-04 at 11 13 08 Screen Shot 2021-10-04 at 11 13 16

Confirmed able to tip bitFlyer KYC'd creator and no messaging was displayed.
Confirmed balance decreased as expected for tip.

Example Example Example Example
Screen Shot 2021-10-04 at 11 13 34 Screen Shot 2021-10-04 at 11 13 44 Screen Shot 2021-10-04 at 11 14 09 Screen Shot 2021-10-04 at 11 15 05
Gemini wallet (funded via Gemini BAT on staging env) - PASSED

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

Example Example Example Example
Screen Shot 2021-10-04 at 11 45 41 AM Screen Shot 2021-10-04 at 11 45 49 AM Screen Shot 2021-10-04 at 11 45 59 AM Screen Shot 2021-10-04 at 11 46 05 AM

Confirmed tip to connected, bitFlyer, and Uphold creators went to pending list and appropriate message (2) was displayed:

Connected Example Connected Example bitFlyer Example bitFlyer Example Uphold Example Uphold Example Wallet Panel Pending Tips List
Screen Shot 2021-10-04 at 11 48 18 AM Screen Shot 2021-10-04 at 11 48 27 AM Screen Shot 2021-10-04 at 11 49 25 AM Screen Shot 2021-10-04 at 11 49 31 AM Screen Shot 2021-10-04 at 11 50 16 AM Screen Shot 2021-10-04 at 11 50 26 AM Screen Shot 2021-10-04 at 11 51 01 AM Screen Shot 2021-10-04 at 11 51 08 AM

Confirmed able to tip Gemini KYC'd creator and no messaging was displayed.
Confirmed balance decreased as expected for tip.

Example Example Example Example
Screen Shot 2021-10-04 at 11 51 48 AM Screen Shot 2021-10-04 at 11 51 58 AM Screen Shot 2021-10-04 at 11 56 06 AM Screen Shot 2021-10-04 at 12 04 53 PM

Verification passed on


Brave | 1.31.71 Chromium: 94.0.4606.71 (Official Build) beta (64-bit)
-- | --
Revision | 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS | Windows 10 Version 21H1 (Build 19043.1237)

Testing notes are available in #17941 (comment)

This was referenced Oct 4, 2021
Closed
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Oct 6, 2021
Closed
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 11, 2021
@stephendonner
Copy link

stephendonner commented Oct 11, 2021 •
edited
Loading

Verified PASSED using

Brave 1.31.81 Chromium: 95.0.4638.40 (Official Build) beta (64-bit)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS Linux

I was able to do all sections except for Gemini, since I couldn't connect to their staging server using my VM & VPN.

Scenario 1 - Not registered - PASSED Confirmed message 1 is displayed on the tipping banner
example example
Screen Shot 2021-10-11 at 12 07 38 PM Screen Shot 2021-10-11 at 11 54 46 AM
Scenario 2 - Registered but not verified, user not verified - PASSED Confirmed no message displayed about publisher status
example example
Screen Shot 2021-10-11 at 12 09 58 PM Screen Shot 2021-10-11 at 12 01 58 PM
Scenario 3 - Registered but not verified, user is verified - PASSED Confirmed message 2 is displayed about publisher status
example example
Screen Shot 2021-10-11 at 12 04 50 PM Screen Shot 2021-10-11 at 12 05 07 PM
Scenario 4 - Verified and user is not connected - PASSED Confirmed no message is displayed about publisher status
example example
Screen Shot 2021-10-11 at 12 13 57 PM Screen Shot 2021-10-11 at 12 14 05 PM
Scenario 5 - Verified with non-matching wallet provider - PASSED Confirmed message 2 is displayed about publisher status
example example
Screen Shot 2021-10-11 at 12 16 08 PM Screen Shot 2021-10-11 at 12 16 16 PM
Scenario 6 - Verified with matching wallet provider - PASSED Confirmed no message is displayed about publisher status
example example
Screen Shot 2021-10-11 at 12 18 33 PM Screen Shot 2021-10-11 at 12 18 43 PM

Additional checks performed:

Anon wallet (funded by UGP grant) - PASSED

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed

example example example example
Screen Shot 2021-10-11 at 12 29 24 PM Screen Shot 2021-10-11 at 12 29 35 PM Screen Shot 2021-10-11 at 12 39 41 PM Screen Shot 2021-10-11 at 12 39 48 PM

Confirmed able to tip connected, Uphold, Gemini, and bitFlyer, KYC'd creators, and no messaging was displayed

connected connected uphold uphold gemini gemini bitflyer bitflyer tips list wallet panel
Screen Shot 2021-10-11 at 12 33 44 PM Screen Shot 2021-10-11 at 12 35 56 PM Screen Shot 2021-10-11 at 12 46 12 PM Screen Shot 2021-10-11 at 12 46 23 PM Screen Shot 2021-10-11 at 12 43 32 PM Screen Shot 2021-10-11 at 12 45 32 PM Screen Shot 2021-10-11 at 12 43 32 PM Screen Shot 2021-10-11 at 12 45 32 PM Screen Shot 2021-10-11 at 12 48 26 PM Screen Shot 2021-10-11 at 12 51 09 PM
Uphold wallet (funded by Uphold BAT on staging env) - PASSED

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

example example example example
Screen Shot 2021-10-11 at 1 08 49 PM Screen Shot 2021-10-11 at 1 09 02 PM Screen Shot 2021-10-11 at 1 09 21 PM Screen Shot 2021-10-11 at 1 09 30 PM

Confirmed tip to connected, Gemini, and bitFlyer creators went to pending list and appropriate message (2) was displayed:

connected connected gemini gemini bitFlyer bitFlyer wallet panel pending tips
Screen Shot 2021-10-11 at 1 24 45 PM Screen Shot 2021-10-11 at 1 24 53 PM Screen Shot 2021-10-11 at 1 25 14 PM Screen Shot 2021-10-11 at 1 25 25 PM Screen Shot 2021-10-11 at 1 23 47 PM Screen Shot 2021-10-11 at 1 24 06 PM Screen Shot 2021-10-11 at 1 25 46 PM Screen Shot 2021-10-11 at 1 26 13 PM

Confirmed able to tip Uphold KYC'd creator and no messaging was displayed.
Confirmed balance decreased as expected for tip.

example example example example
Screen Shot 2021-10-11 at 1 30 29 PM Screen Shot 2021-10-11 at 1 30 44 PM Screen Shot 2021-10-11 at 1 31 08 PM Screen Shot 2021-10-11 at 1 31 21 PM
bitFlyer wallet (funded by bitFlyer BAT on staging env) - PASSED

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

example example example example
Screen Shot 2021-10-11 at 1 40 20 PM Screen Shot 2021-10-11 at 1 40 26 PM Screen Shot 2021-10-11 at 1 40 48 PM Screen Shot 2021-10-11 at 1 41 06 PM

Confirmed tip to connected, Gemini, and Uphold creators went to pending list and appropriate message (2) was displayed.
Confirmed balance decreased as expected for tip.

connected connected gemini gemini uphold uphold wallet panel pending tips
Screen Shot 2021-10-11 at 1 45 11 PM Screen Shot 2021-10-11 at 1 45 21 PM Screen Shot 2021-10-11 at 1 45 54 PM Screen Shot 2021-10-11 at 1 46 01 PM Screen Shot 2021-10-11 at 1 46 55 PM Screen Shot 2021-10-11 at 1 47 02 PM Screen Shot 2021-10-11 at 1 47 27 PM Screen Shot 2021-10-11 at 1 47 18 PM

Confirmed able to tip bitFlyer KYC'd creator and no messaging was displayed.
Confirmed balance decreased as expected for tip.

example example example example
Screen Shot 2021-10-11 at 1 51 36 PM Screen Shot 2021-10-11 at 1 51 43 PM Screen Shot 2021-10-11 at 1 53 10 PM Screen Shot 2021-10-11 at 1 53 18 PM
Gemini wallet (funded by Gemini BAT on staging env) - TBD

Unable to run due to VM & VPN issues, preventing me from connecting to Gemini staging:

example example
Screen Shot 2021-10-11 at 2 05 30 PM Screen Shot 2021-10-11 at 2 14 54 PM

@stephendonner stephendonner added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 11, 2021
@kjozwiak kjozwiak mentioned this issue Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Adjust unverified publisher note display logic brave/brave-core
4 participants
@stephendonner @zenparsing @LaurenWags @GeetaSarvadnya