Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safe_browsing_mode=2 for Android (Uplift for 1.7.x) #8681

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Mar 13, 2020

Uplift for PR #8664

Fix #8381

please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bbondy bbondy added this to the 1.7.x - Beta milestone Mar 13, 2020
@bbondy bbondy requested a review from a team March 13, 2020 14:12
@bbondy bbondy self-assigned this Mar 13, 2020
@kjozwiak
Copy link
Member

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. As per #8681 (comment), the only failure was lint on all platforms due to a known issue. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 671b330 into 1.7.x Mar 13, 2020
@kjozwiak kjozwiak deleted the safe-browser-android-1.7.x branch March 13, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants