Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Safe Browsing doesn't work in android-core #8381

Closed
fmarier opened this issue Feb 24, 2020 · 3 comments · Fixed by #8664
Closed

[Android] Safe Browsing doesn't work in android-core #8381

fmarier opened this issue Feb 24, 2020 · 3 comments · Fixed by #8664
Labels
feature/safebrowsing OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes security
Milestone
Closed / Dupe / I...

Comments

@fmarier
Copy link
Member

fmarier commented Feb 24, 2020 •
edited
Loading

Description

Safe Browsing isn't blocking anything in android core.

Steps to reproduce

  1. Visit https://testsafebrowsing.appspot.com/
  2. Try all of the links in the "Webpage Warnings"

Actual result

Not blocked.

Expected result

Should be showing the red interstitial pages just like on desktop.

Issue reproduces how often

always

Issue happens on

  • Current Play Store version? no
  • Beta build? yes

Device details

  • Device (Phone, Tablet, Phablet): Pixel 3a
  • Android version: 10

Brave version

1.5.97 Chromium: 80.0.3987.116 (Official Build) beta (32-bit)
Revision	dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS	Android 10; Pixel 3a Build/QQ1A.200205.002
@fmarier fmarier added security OS/Android Fixes related to Android browser functionality labels Feb 24, 2020
@diracdeltas diracdeltas added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Mar 10, 2020
@anthonypkeane anthonypkeane added this to the Android 1.7.x Release milestone Mar 10, 2020
@anthonypkeane
Copy link

Internal chat: https://bravesoftware.slack.com/archives/CM17J5QMU/p1583873767126500

@bbondy bbondy added QA/Yes priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Mar 12, 2020
@bbondy bbondy mentioned this issue Mar 12, 2020
Merged
29 tasks
This was referenced Mar 13, 2020
Merged
Merged
@srirambv
Copy link
Contributor

This is not working on 1.5.111 x64 stable build. Recording here https://bravesoftware.slack.com/archives/CM17J5QMU/p1584349279170400

@srirambv srirambv mentioned this issue Mar 16, 2020
Closed
@srirambv
Copy link
Contributor

Superseded by #8705. Moving out of milestone

@srirambv srirambv removed this from the Android Beta Release 7 milestone Mar 16, 2020
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
This was referenced Feb 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/safebrowsing OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes security
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

Successfully merging a pull request may close this issue.

Use safe_browsing_mode=2 for Android brave/brave-browser
6 participants
@fmarier @diracdeltas @bbondy @kjozwiak @anthonypkeane @srirambv