Adding a runtime switch for Smart Tracking Protection #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opening instead of #3026 - to ease the CI workflow |
16 tasks
jumde
force-pushed
the
stp
branch
2 times, most recently
from
4dcb157 to
1418233
Compare
jumde
commented
Apr 3, 2019
package.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "upload": "node ./scripts/commands.js upload", | |||
| "update_patches": "node ./scripts/commands.js update_patches", | |||
| "apply_patches": "node ./scripts/sync.js --run_hooks", | |||
| "start": "node ./scripts/commands.js start", | |||
| "start": "node ./scripts/commands.js start --enable-smart-tracking-protection", | |||
There was a problem hiding this comment.
To-Do: Revert before merge. STP will be disabled by default
jumde
commented
Apr 3, 2019
package.json
Outdated
| @@ -42,7 +42,7 @@ | |||
| }, | |||
| "brave-core": { | |||
| "dir": "src/brave", | |||
| "branch": "master", | |||
| "branch": "stp", | |||
There was a problem hiding this comment.
To-Do: Revert before merge.
jumde
commented
Apr 3, 2019
lib/config.js
Outdated
| @@ -84,6 +84,7 @@ Config.prototype.buildArgs = function () { | |||
| is_debug: this.buildConfig !== 'Release', | |||
| dcheck_always_on: this.buildConfig !== 'Release', | |||
| brave_channel: this.channel, | |||
| brave_stp_enabled: true, | |||
There was a problem hiding this comment.
To-Do: Revert before merge. STP will be disabled by default
jumde
force-pushed
the
stp
branch
8 times, most recently
from
f18f7c8 to
4e0388b
Compare
jumde
force-pushed
the
stp
branch
8 times, most recently
from
94b5256 to
ac521b8
Compare
jumde
force-pushed
the
stp
branch
3 times, most recently
from
ba6d006 to
4a64b04
Compare
STP can cause webompat issues, gating this feature behind off-by-default runtime flag till the feature is thoroughly tested for webcompat. The switches are available here: https://github.com/brave/brave-core/pull/403/files auditors: @bridiver, @bsclifton, @iefremov
iefremov
approved these changes
Apr 18, 2019
|
Marking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3025
Description
STP can cause webcompat issues, so gating this feature behind off-by-default runtime flag till the feature is thoroughly tested.
More details about the feature/switches is available here:
brave/brave-core#403
Please reach out if you have any questions.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
The test plan for this change is covered in: brave/brave-core#403 (For Devs - Enable STP runtime and buildflags)
Reviewer Checklist: