Issue 3025: Add a buildflag/runtime switch to disable STP by default #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumde
force-pushed
the
stp_runtime_switch
branch
2 times, most recently
from
1f83853 to
f6f1258
Compare
STP can cause webompat issues, gating this feature behind off-by-default runtime flag till the feature is thoroughly tested for webcompat. The switches are available here: https://github.com/brave/brave-core/pull/403/files auditors: @bridiver, @bsclifton
jumde
force-pushed
the
stp_runtime_switch
branch
from
f6f1258 to
97f68a4
Compare
16 tasks
|
Tracking the work here: #3888 |
|
@jumde can this branch be deleted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3025
Description
STP can cause webcompat issues, so gating this feature behind off-by-default runtime flag till the feature is thoroughly tested.
More details about the feature/switches is available here:
brave/brave-core#403
auditors: @bridiver, @bsclifton
Please reach out if you have any questions.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
The test plan for this change is covered in: brave/brave-core#403 (For Devs - Enable STP runtime and buildflags)
Reviewer Checklist: