Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme resources are always copied which triggers unnecessary rebuilds #989

Closed
bridiver opened this issue Sep 6, 2018 · 0 comments · Fixed by #990
Closed

Theme resources are always copied which triggers unnecessary rebuilds #989

bridiver opened this issue Sep 6, 2018 · 0 comments · Fixed by #990
Assignees
@bridiver
Labels
QA/No
Milestone
0.55.x - Release ...

Comments

@bridiver
Copy link
Contributor

bridiver commented Sep 6, 2018

Description

Brave theme resources are copied on every build run even if they are the same

Steps to Reproduce

  1. npm run build

Actual result:

theme resources are copied

Expected result:

theme resources should only be copied if they are different

Reproduces how often:

always

Brave version (about:brave info)

Reproducible on current release:

yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
QA/No
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

only copy theme resources when they actually change brave/brave-browser
2 participants
@bridiver @bbondy