Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to re-enable generation of LICENSE files #8618

Closed
fmarier opened this issue Mar 10, 2020 · 2 comments · Fixed by #8560
Closed

Need to re-enable generation of LICENSE files #8618

fmarier opened this issue Mar 10, 2020 · 2 comments · Fixed by #8560

Comments

@fmarier
Copy link
Member

fmarier commented Mar 10, 2020

Test plan

Likely steps a developer will need to do 😄

  1. Queue build of 1.7
  2. Ensure builds succeed
  3. Verify that license generation portion of build (on each platform) was done during create_dist
  4. Mark issue as verified!

Description

#8616 temporarily disabled license generation in order to fix a build failure (#8615).

We need to make sure it's re-enabled (likely by #8560) since we can't ship 1.7 without it.

@fmarier fmarier added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Mar 10, 2020
@fmarier fmarier added this to the 1.7.x - Nightly milestone Mar 10, 2020
@fmarier fmarier self-assigned this Mar 10, 2020
@fmarier fmarier modified the milestones: 1.7.x - Beta, 1.8.x - Nightly Mar 10, 2020
fmarier added a commit that referenced this issue Mar 10, 2020
This will ensure that the licensing script runs for all CI builds
even if we change the build config for them.
fmarier added a commit that referenced this issue Mar 10, 2020
This will ensure that the licensing script runs for all CI builds
even if we change the build config for them.
bsclifton added a commit that referenced this issue Mar 11, 2020
…-1.7.x

Move LICENSE file generation to create_dist (fixes #8618)
@bsclifton
Copy link
Member

Added some steps we can try when queueing the next 1.7 build 😄

@btlechowski
Copy link

btlechowski commented Mar 23, 2020

Verification passed on

Brave 1.7.70 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

Verified test plan from #8560
image
image

Verification passed on

Brave 1.7.67 Chromium: 80.0.3987.149 (Official Build) beta (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

-Verified test plan from #8560
"Background images"

image

"Brave Ad Block"
image


Verified passed with

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Background Images
Screen Shot 2020-03-24 at 9 36 33 AM

Brave Ad Block
Screen Shot 2020-03-24 at 9 36 58 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants