Move LICENSE file generation to create_dist (fixes #8618)

This will ensure that the licensing script runs for all CI builds even if we change the build config for them.
brave · Mar 10, 2020 · e63ca48 · e63ca48
1 parent c66871d
commit e63ca48
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/lib/build.js b/lib/build.js
@@ -1,5 +1,4 @@
 const config = require('../lib/config')
-const licensing = require('../lib/licensing')
 const util = require('../lib/util')
 const path = require('path')
 const fs = require('fs-extra')
@@ -94,10 +93,6 @@ const build = (buildConfig = config.defaultBuildConfig, options) => {
   touchOverriddenFiles()
   touchOverriddenVectorIconFiles()
   util.updateBranding()
-  if (buildConfig === 'Release') {
-    // TODO(bsclifton): uncomment when we can address problem
-    // licensing.updateLicenses()
-  }
 
   if (config.xcode_gen_target) {
     util.generateXcodeWorkspace()

diff --git a/lib/createDist.js b/lib/createDist.js
@@ -1,4 +1,5 @@
 const config = require('../lib/config')
+const licensing = require('../lib/licensing')
 const util = require('../lib/util')
 const path = require('path')
 const fs = require('fs-extra')
@@ -14,6 +15,7 @@ const createDist = (buildConfig = config.defaultBuildConfig, options) => {
   }
 
   util.updateBranding()
+  licensing.updateLicenses()
   fs.removeSync(path.join(config.outputDir, 'dist'))
   config.buildTarget = 'create_dist'
   util.buildTarget()