Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Import history from Safari #8515

Closed
rebron opened this issue Mar 4, 2020 · 3 comments · Fixed by brave/brave-core#5383
Closed

[Desktop] Import history from Safari #8515

rebron opened this issue Mar 4, 2020 · 3 comments · Fixed by brave/brave-core#5383

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 4, 2020

Description

Support importing 'History' from Safari and update the Import Bookmarks & Settings... dialog to show History option, checked by default if History in Safari is present.

Expected Results

  1. Select Import Bookmarks and Settings... from the Brave app menu or from brave://settings/getStarted
  2. Select Safari if not already selected.
  3. User only sees Favorites/Bookmarks checkbox.
  4. User should also see a check box item [that is selected checked] for History.
  5. Upon selecting import, prompt for Full Disk access.

75483199-31c34c00-595b-11ea-968b-185c79a99efe

Related to: #2710

@rebron
Copy link
Collaborator Author

rebron commented Mar 10, 2020

cc: @simonhong

@simonhong
Copy link
Member

Upstream code refers History.plist for importing Safari history.
However, Safari doesn't use it anymore. It uses History.db now.

@LaurenWags
Copy link
Member

LaurenWags commented Jun 24, 2020

Verified passed with

Brave | 1.11.75 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description
  • Confirmed after allowing Full Disk Access in preferences (and restarting Brave Dev), I could import Browsing history individually, Favorites/Bookmarks individually, or both together.

Screen Shot 2020-06-24 at 8 40 52 AM

cc @kjozwiak to check on Catalina


Verification PASSED on macOS 10.15.5 x64 using the following build:

Brave | 1.11.80 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.15.5 (Build 19F101)

Screen Shot 2020-06-30 at 12 04 53 AM

@rebron rebron changed the title Import history from Safari [Desktop] Import history from Safari Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants