Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with importing history from Safari 13 #21775

Open
BelKed opened this issue Mar 19, 2022 · 3 comments
Open

Problem with importing history from Safari 13 #21775

BelKed opened this issue Mar 19, 2022 · 3 comments

Comments

@BelKed
Copy link

BelKed commented Mar 19, 2022

Description

When I want to import history from Safari 13.1.2 (13609.3.5.1.5), the option for that is not displayed...

Steps to Reproduce

  1. Open Brave
  2. Go to brave://settings/importData
  3. Select Safari
  4. See only the "Favourites/bookmarks" option

Actual result

Screen Shot 2022-03-19 at 08 47 51

Expected result

There should also be a "History" option for importing history from Safari as for importing from other browsers (Firefox, Chrome, ...). Something like this:

Screen Shot 2022-03-19 at 08 51 16

Reproduces how often

Easily reproduced I think

Brave version (brave://version info)

Brave 1.36.117 Chromium: 99.0.4844.74 (Official Build) (x86_64)
Revision fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS macOS Version 10.13.6 (Build 17G14042)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Yes

Screen Shot 2022-03-19 at 08 42 01

@rebron rebron added retention QA/Yes needs-investigation A bug not 100% confirmed/fixed release-notes/include priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. and removed needs-investigation A bug not 100% confirmed/fixed QA Pass-macOS labels Mar 22, 2022
@rebron rebron removed the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 22, 2022
@rebron
Copy link
Collaborator

rebron commented Mar 22, 2022

Related to #8515 May need to full disk access in order to do import from History.

@BelKed
Copy link
Author

BelKed commented Mar 22, 2022

Well, there was no popup that would indicate, that it needs Full Disk Access...
It also doesn't appear in the Full Disk Access section of System Preferences – it was probably not even requested by Brave browser.

Screen Shot 2022-03-22 at 20 52 32

@BelKed
Copy link
Author

BelKed commented Mar 28, 2022

Now I realised that the Full Disk Access feature was introduced in macOS Mojave (10.14), so it's probably not related to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: P4 Backlog
Development

No branches or pull requests

2 participants