Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash ID isn't uploaded immediately even with setting set to send #842

Closed
srirambv opened this issue Aug 25, 2018 · 8 comments
Closed

Crash ID isn't uploaded immediately even with setting set to send #842

srirambv opened this issue Aug 25, 2018 · 8 comments

Comments

@srirambv
Copy link
Contributor

Description

Crash ID isn't uploaded immediately even with setting set to send

Steps to Reproduce

  1. Launch a new profile on Windows
  2. Visit chrome://crash in a new tab, ensure webview crashes
  3. Open chrome://crashes in a new tab, crash id is auto uploaded
  4. Visit https://neowin.net in a new tab, browser crashes (existing issue)
  5. Open chrome://crasehs, shows 6 crash reports none of them are auto uploaded
  6. Click Send now on crash id, doesn't send, restart the browser, crash id is uploaded

Actual result:

crashid

Expected result:

Should upload crash id immediately when the crash report is generated and setting is set to send crash reports

Reproduces how often:

100%

Brave version (about:brave info)

Brave 0.54.1 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows
JavaScript V8 6.9.427.14
Flash 30.0.0.154 C:\Windows\system32\Macromed\Flash\pepflashplayer64_30_0_0_154.dll

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @bridiver
@bbondy please move it to release milestone if required and ad as blocking

@srirambv srirambv added this to the Backlog milestone Aug 25, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 16, 2019

The crash ID isn't uploaded. By default send crash report is enabled in Beta even though crash ID isn't uploaded, even browser restart doesn't help

Brave 0.69.107 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)

Crash Id isn't uploaded in Release channel even after enabling send crash reports checkbox in privacy settings.

Crash report ID isn't uploaded

Brave 0.68.129 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)
Brave 0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)

@bridiver
Copy link
Contributor

@GeetaSarvadnya did you restart the browser? There is throttling on the crash upload and sometimes it doesn't show up until you restart

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 11, 2019

@bridiver I have restarted the browser also Automatic crash switch was turned ON in settings page

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 10, 2020

Logged a new issue #10202 for #842 (comment)

@bridiver
Copy link
Contributor

@GeetaSarvadnya this is the expected behavior. Crash ids are uploaded every hour or on restart

@bridiver
Copy link
Contributor

bridiver commented Jun 10, 2020

// This currently implements very simplistic rate-limiting, compatible with
  // the Breakpad client, where the strategy is to permit one upload attempt per
  // hour, and retire reports that would exceed this limit or for which the
  // upload fails on the first attempt.
  //
  // If upload was requested explicitly (i.e. by user action), we do not
  // throttle the upload.
  //
  // TODO(mark): Provide a proper rate-limiting strategy and allow for failed
  // upload attempts to be retried.

@bridiver
Copy link
Contributor

@GeetaSarvadnya if more than one hour passes without uploading then there might be an issue we need to look at

@bsclifton
Copy link
Member

Closing as this is expected behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants