Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show 'Add to Brave' instead of 'Add to Chrome' in Chrome Web Store #790

Closed
rebron opened this issue Aug 20, 2018 · 6 comments · Fixed by brave/brave-core#2845
Closed

Show 'Add to Brave' instead of 'Add to Chrome' in Chrome Web Store #790

rebron opened this issue Aug 20, 2018 · 6 comments · Fixed by brave/brave-core#2845

Comments

@rebron
Copy link
Collaborator

rebron commented Aug 20, 2018

Description

Change 'Add to Chrome' button on Chrome Web Store to display 'Add to Brave' instead in order to start Extension install process from Chrome Web Store.

Test plan / Steps to Reproduce

Change

  1. Go to https://chrome.google.com/webstore/category/extensions?hl=en-US&utm_source=chrome-ntp-launcher
  2. Select Extension e.g. https://chrome.google.com/webstore/detail/grammarly-for-chrome/kbfnbcaeplbcioakkpcpgfkobkghlhen?hl=en-US&utm_source=chrome-ntp-launcher
  3. Look at the Add to X button.

Actual result:

addtochromebutton
Shows Add to Chrome.

Expected result:

addtobravebutton
Expected results, Add to Brave.

Reproduces how often:

Brave version (about:brave info)

Reproducible on current release:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@rebron rebron changed the title Change to 'Add to Brave' instead of Add to Chrome CWS Change to 'Add to Brave' instead of 'Add to Chrome' CWS Aug 20, 2018
@bbondy bbondy added this to the 1.0 milestone Aug 29, 2018
@bbondy bbondy modified the milestones: 1.0 (0.56.x), 1.x Backlog Sep 29, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@Sophist-UK
Copy link

Also shows "Add to Chrome" in the search results / list of extensions, and "Remove from Chrome" after extension has been installed.

If Brave wants to be consistent, it needs to have an internal extension that changes the text as sent from the Chrome web store. This might be best implemented by including as standard (if it doesn't create security issues which it might well do) script functionality aka GreaseMonkey.

@stardust3dd
Copy link

Can I claim this issue?

@bsclifton
Copy link
Member

@stardust3dd sure - you're welcome to grab this. Have you gotten Brave up and running locally? You can likely handle this with a content script in the Brave extension

@stardust3dd
Copy link

The chrome webstore does not allow content scripts on it's pages since version 35. Do we have any other way around?

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 4, 2019
@kkuehlz
Copy link
Contributor

kkuehlz commented Jul 2, 2019

PR in brave/brave-core#2845

kkuehlz pushed a commit to kkuehlz/brave-core that referenced this issue Jul 3, 2019
Change all buttons in the DOM with labels "Add to Chrome" and "Remove
from Chrome" to "Add to Brave" and "Remove from Brave" respectively.

Fixes brave/brave-browser#790
@btlechowski
Copy link

btlechowski commented Aug 20, 2019

LGTM. Awesome work!

Verification passed on

Brave 0.69.110 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Logged #5730

Before adding the extension:
image
After adding the extension:
image

Verified passed with

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24494)

Before adding the extension:
image

After adding the extension:
image

@rebron rebron changed the title Change to 'Add to Brave' instead of 'Add to Chrome' CWS Show 'Add to Brave' instead of 'Add to Chrome' in Chrome Web Store Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants