-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show 'Add to Brave' instead of 'Add to Chrome' in Chrome Web Store #790
Comments
Also shows "Add to Chrome" in the search results / list of extensions, and "Remove from Chrome" after extension has been installed. If Brave wants to be consistent, it needs to have an internal extension that changes the text as sent from the Chrome web store. This might be best implemented by including as standard (if it doesn't create security issues which it might well do) script functionality aka GreaseMonkey. |
Can I claim this issue? |
@stardust3dd sure - you're welcome to grab this. Have you gotten Brave up and running locally? You can likely handle this with a content script in the Brave extension |
The chrome webstore does not allow content scripts on it's pages since version 35. Do we have any other way around? |
PR in brave/brave-core#2845 |
Change all buttons in the DOM with labels "Add to Chrome" and "Remove from Chrome" to "Add to Brave" and "Remove from Brave" respectively. Fixes brave/brave-browser#790
LGTM. Awesome work! Verification passed on
Logged #5730 Before adding the extension: Verified passed with
Verification passed on
|
Description
Change 'Add to Chrome' button on Chrome Web Store to display 'Add to Brave' instead in order to start Extension install process from Chrome Web Store.
Test plan / Steps to Reproduce
Change
Add to X
button.Actual result:
Shows
Add to Chrome
.Expected result:
Expected results,
Add to Brave
.Reproduces how often:
Brave version (about:brave info)
Reproducible on current release:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: