-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing scope for Uphold #7713
Labels
feature/rewards
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
mandar-brave
added
feature/rewards
priority/P1
A very extremely bad problem. We might push a hotfix for it.
labels
Jan 13, 2020
32 tasks
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Jan 16, 2020
Both brave/brave-core#4409 and brave/brave-core#4410 and have been uplifted. This should be available for QA in the next build. |
Needs fixes from brave/brave-core#4372 uplifted to fully test this per brave/brave-core#4379 (comment). Once those are uplifted this can be retested. |
Verified passed using
Verification passed on
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/rewards
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
As a future plan to support add-funds to Uphold user wallets via top-up, and eventually monthly subscribed top-ups, we need to ask user authorization for new scopes (manifest changes) when we authenticate against Uphold.
This feature will allow us;
Feature to support future payments projects and subscription projects requires this change. Since re-auth is 90 days, it would be good to get the manifest change in as early as possible.
cc @NejcZdovc @rebron @jumde @evq
The text was updated successfully, but these errors were encountered: