Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing scope for Uphold #7713

Closed
mandar-brave opened this issue Jan 13, 2020 · 3 comments · Fixed by brave/brave-core#4379
Closed

Changing scope for Uphold #7713

mandar-brave opened this issue Jan 13, 2020 · 3 comments · Fixed by brave/brave-core#4379

Comments

@mandar-brave
Copy link

As a future plan to support add-funds to Uphold user wallets via top-up, and eventually monthly subscribed top-ups, we need to ask user authorization for new scopes (manifest changes) when we authenticate against Uphold.

This feature will allow us;

  • to be authorized to take a credit card and fund user wallet
  • and directly transfer BAT to the user wallet

Feature to support future payments projects and subscription projects requires this change. Since re-auth is 90 days, it would be good to get the manifest change in as early as possible.

cc @NejcZdovc @rebron @jumde @evq

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jan 13, 2020
@NejcZdovc NejcZdovc added this to the 1.3.x - Beta milestone Jan 13, 2020
@NejcZdovc NejcZdovc self-assigned this Jan 13, 2020
@rebron rebron changed the title Chaning scope for Uphold Changing scope for Uphold Jan 14, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 16, 2020
@kjozwiak
Copy link
Member

Both brave/brave-core#4409 and brave/brave-core#4410 and have been uplifted. This should be available for QA in the next build.

@LaurenWags
Copy link
Member

Needs fixes from brave/brave-core#4372 uplifted to fully test this per brave/brave-core#4379 (comment). Once those are uplifted this can be retested.

@LaurenWags
Copy link
Member

LaurenWags commented Feb 3, 2020

Verified passed using

Brave 1.3.106 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)

KYC-panelsummary

KYC-tippanels

KYC-contrib_info-table

KYC-contrib_info_pub-table

Verification passed on

Brave 1.3.107 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.3.111 Chromium: 80.0.3987.85 (Official Build) (64-bit)
Revision 583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS Ubuntu 18.04 LTS

image
image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants