-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra Toolbar Spacing #791
Labels
design
A design change, especially one which needs input from the design team
feature/user-interface
All UI related
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
Milestone
Comments
petemill
added
the
design
A design change, especially one which needs input from the design team
label
Aug 20, 2018
Merged
11 tasks
Verification Passed on
Verified passed with
Verification Passed on
|
This was referenced Feb 5, 2020
This was referenced Feb 5, 2020
This was referenced Feb 6, 2020
This was referenced Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
A design change, especially one which needs input from the design team
feature/user-interface
All UI related
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
At the moment there are fixed width items on the toolbar, and expanding items.
Fixed items:
Expanding items:
The expanding items take up the remaining space after the fixed items are given space. There is an algorithm that determines the ratio of space allocated to LocationBar and BrowserActions.
A further complication is that the BrowserActions area is semi-fixed in that it has a dynamic max-width depending on how many extensions are installed.
With Brave, the intention is to add a third expanding item:
We need to decide exactly how this Space item is to take width away from both the LocationBar and the BrowserActions given the varying maximum's of each.
The text was updated successfully, but these errors were encountered: