Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claiming grant from NTP widget does not remove claim banner from brave://rewards #6741

Closed
LaurenWags opened this issue Nov 3, 2019 · 4 comments · Fixed by brave/brave-core#3880

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Nov 3, 2019

Description

If you claim a grant (UGP or Ads) from the NTP widget, the panel opens to claim the grant as expected and you can successfully claim from there.

Then, if you go to brave://rewards, the claim banner is still there. Refresh of page and reopening the tab do not make the banner go away.

Steps to Reproduce

  1. Clean profile (staging)
  2. Enable rewards.
  3. On widget, claim the UGP grant.
  4. Panel opens, complete captcha. Close successful message.
  5. Go to brave://rewards page.

Actual result:

below is an example using Ad grant, but same thing happens for UGP grant:
Screen Shot 2019-11-03 at 5 09 50 PM

If you attempt to claim from this banner and complete captcha, you get this:
Screen Shot 2019-11-03 at 5 10 29 PM

Expected result:

Once Ad or UGP grant is claimed, banner should not be shown on brave://rewards page

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.73.55 Chromium: 78.0.3904.87 (Official Build) nightly (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @mandar-brave @ryanml @brave/legacy_qa

@LaurenWags
Copy link
Member Author

LaurenWags commented Nov 3, 2019

Note - Issue does not reproduce with the following STR (bypassing NTP widget entirely):

  1. Clean profile (staging)
  2. Enable Rewards (used panel)
  3. Saw BAT logo notification about UGP grant, clicked on BAT logo.
  4. Clicked on 'Claim' button on panel notification
  5. Completed captcha, got successful message. Closed successful message.
  6. Navigated to brave://rewards page
    --> no claim banner notification

Screen Shot 2019-11-03 at 5 23 11 PM

@mandar-brave
Copy link

@NejcZdovc seems duplicate of the issue we were observing on iOS.
if there is a PR to fix that, that may fix the redundant grant claim issue.

@NejcZdovc
Copy link
Contributor

@mandar-brave this is a different issue as here we have old logic, where iOS has VG

@btlechowski
Copy link

btlechowski commented Dec 4, 2019

Verification passed on

Brave 1.3.50 Chromium: 79.0.3945.56 (Official Build) nightly (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS Ubuntu 18.04 LTS

Verified test plan from the description.

image

Verification passed on

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified test plan from the description.
Claim UGP grants from widget:
image

Claim Ad grants from widget:
image

image

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)
  • ensured that the UGP notification isn't being displayed under brave://rewards when accepting the grant using the rewards widget via brave://newtab
  • ensured that the UGP notification isn't being displayed under the rewards widget via brave://newtabwhen accepting the grant using brave://rewards
  • Went through the above cases with both UGP & Ad grants and ensured the correct notifications were being dismissed in both the rewards widget and brave://rewards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment