Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Brave rewards is OFF uphold page loads forever when verifying wallet from the settings page #5780

Closed
GeetaSarvadnya opened this issue Aug 23, 2019 · 1 comment · Fixed by brave/brave-core#3338

Comments

@GeetaSarvadnya
Copy link

Description

When Brave rewards is OFF uphold page loads forever when verifying wallet from the settings page

Steps to Reproduce

  1. Clean profile 069.114
  2. Join rewards
  3. Turn OFF brave rewards switch in brave://rewards page
  4. Click on Verify wallet in setting page
  5. Click on VERIFY WALLET in verify modal
  6. Login uphold using existing uphold account
  7. Uphold page loads forever

Actual result:

Uphold page loads forever when verifying wallet from the settings page
image

Expected result:

Uphold account should open - not sure how it should behave when brave rewards is turned OFF

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.69.114 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@brave/legacy_qa @NejcZdovc @mandar-brave

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Oct 7, 2019

Verification passed on

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 0.70.110 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description

Verification passed on

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS
  • Verified STR from description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment