Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git-secrets | truffle-hog as a pre-push hook #552

Open
5 tasks
jumde opened this issue Jul 13, 2018 · 2 comments
Open
5 tasks

Add git-secrets | truffle-hog as a pre-push hook #552

jumde opened this issue Jul 13, 2018 · 2 comments
Labels
audit-non-blocking priority/P4 Planned work. We expect to get to it "soon".

Comments

@jumde
Copy link
Contributor

jumde commented Jul 13, 2018

truffleHog --entropy=False https://github.com/brave/
git secrets --scan -r .

  • brave-browser
  • brave-core
  • ad-block
  • brave-extension
  • tracking-protection
@bbondy bbondy added this to the Backlog milestone Jul 16, 2018
@bbondy bbondy modified the milestones: Backlog, Releasable builds 0.55.x Aug 10, 2018
@jumde jumde modified the milestones: Releasable builds 0.55.x, Backlog Aug 16, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, 1.0 (0.56.x) Oct 1, 2018
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Oct 31, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@bsclifton
Copy link
Member

@jumde is this still valid?

@jumde
Copy link
Contributor Author

jumde commented Aug 31, 2020

@bsclifton - This is still valid, we don't have any way to protect developers from committing secrets accidentally as part of a pre-commit/pre-push hook.

@btlechowski btlechowski mentioned this issue Sep 14, 2020
Closed
This was referenced Sep 16, 2020
Closed
Closed
Closed
@btlechowski btlechowski mentioned this issue Sep 18, 2020
Open
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Sep 18, 2020
Closed
@btlechowski btlechowski mentioned this issue Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit-non-blocking priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tildelowengrimm @bbondy @jumde @bsclifton @rebron @mbacchi